From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 58664993D6 for ; Tue, 14 Nov 2023 10:14:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 366811CE4B for ; Tue, 14 Nov 2023 10:13:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 14 Nov 2023 10:13:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 52E774278F for ; Tue, 14 Nov 2023 10:13:29 +0100 (CET) Message-ID: <8f60db3b-d76e-430a-8904-f14cb66abc4b@proxmox.com> Date: Tue, 14 Nov 2023 10:13:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Friedrich Weber References: <20231113170916.184994-1-f.weber@proxmox.com> <20231113170916.184994-3-f.weber@proxmox.com> From: Fiona Ebner In-Reply-To: <20231113170916.184994-3-f.weber@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.079 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [qemuserver.pm] Subject: Re: [pve-devel] [PATCH qemu-server 2/2] vm start: warn if using ballooning and PCI(e) passthrough X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2023 09:14:00 -0000 Am 13.11.23 um 18:09 schrieb Friedrich Weber: > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index dbcd568..70983a4 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -5789,6 +5789,16 @@ sub vm_start_nolock { > die $err; > } > > + if ( > + scalar(%$pci_devices) Style nit: we usually check for scalar(keys ...) > + && defined($conf->{balloon}) > + && $conf->{balloon} != 0 It's nice being explicit, but replacing the above two with just $conf->{balloon}, the whole if expression would fit in one line rather than six. Either way is fine by me, but the vm_start_nolock function is already pretty long. Also might make sense to move the PCI stuff into a helper, if you'd like to give it a shot. But not a requirement for this patch. > + && $conf->{balloon} != $memory > + ) { > + log_warn("Ballooning is not possible when using PCI(e) passthrough, " > + ."VM will use maximum configured memory ($memory MiB).\n"); Trailing newline is not required for log_warn(). Style nit: wrong indentation, we don't usually align text like this. It should just be one more indentation for the second line. All just nits, so: Reviewed-by: Fiona Ebner