From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8B3816424B for ; Thu, 29 Oct 2020 19:21:49 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73204BBBD for ; Thu, 29 Oct 2020 19:21:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 62A08BBB1 for ; Thu, 29 Oct 2020 19:21:18 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 23E3D45F96; Thu, 29 Oct 2020 19:21:18 +0100 (CET) To: Proxmox VE development discussion , =?UTF-8?Q?Jan-Jonas_S=c3=a4mann?= References: <4e2bd780-260b-d757-e108-8ea8bb57c0df@proxmox.com> <20201024192709.27324-1-sprinterfreak@binary-kitchen.de> <20201024192709.27324-2-sprinterfreak@binary-kitchen.de> From: Thomas Lamprecht Message-ID: <8f4377de-7b18-461b-4882-26a7e59affa1@proxmox.com> Date: Thu, 29 Oct 2020 19:21:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201024192709.27324-2-sprinterfreak@binary-kitchen.de> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.287 Adjusted score from AWL reputation of From: address GAPPY_SUBJECT 0.1 Subject: contains G.a.p.p.y-T.e.x.t KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.921 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [diskmanage.pm] Subject: Re: [pve-devel] [PATCH v2 storage] Diskmanage: Use S.M.A.R.T. attributes for SSDs wearout lookup X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Oct 2020 18:21:49 -0000 On 24.10.20 21:27, Jan-Jonas S=C3=A4mann wrote: > This replaces a locally maintained hardware map in > get_wear_leveling_info() by commonly used register names of > smartmontool. Smartmontool maintains a labeled register database that > contains a majority of drives (including versions). The current lookup > produces false estimates, this approach hopefully provides more reliabl= e > data. >=20 > Signed-off-by: Jan-Jonas S=C3=A4mann > --- > PVE/Diskmanage.pm | 58 +++++++++++++++++++++++------------------------= > 1 file changed, 28 insertions(+), 30 deletions(-) so, I was about to apply this, but it fails the disks test now, could you= please adapt them so that the new checks are covered. The respective test could be run standalone with: # cd test # ./run_disk_tests.pl