From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D072468EFD for ; Tue, 22 Mar 2022 10:31:43 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C40811BEED for ; Tue, 22 Mar 2022 10:31:43 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 037261BEE2 for ; Tue, 22 Mar 2022 10:31:42 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B4D3146EB7 for ; Tue, 22 Mar 2022 10:31:42 +0100 (CET) Message-ID: <8f1859ba-c782-7dee-09e6-7fac1561ce74@proxmox.com> Date: Tue, 22 Mar 2022 10:31:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, =?UTF-8?Q?Fabian_Gr=c3=bcnbichler?= References: <20220321130633.62086-1-f.ebner@proxmox.com> <20220321130633.62086-2-f.ebner@proxmox.com> <159a4067-39b4-c63a-c267-189c908465c3@proxmox.com> From: Fabian Ebner In-Reply-To: <159a4067-39b4-c63a-c267-189c908465c3@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.118 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, storage.pm] Subject: Re: [pve-devel] [PATCH storage 1/4] check volume access: allow if user has VM.Config.Disk X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 09:31:43 -0000 Am 22.03.22 um 09:31 schrieb Fabian Ebner: > Am 21.03.22 um 14:06 schrieb Fabian Ebner: >> Listing guest images should not require Datastore.Allocate in this >> case. In preparation for adding disk import to the GUI. >> >> Signed-off-by: Fabian Ebner >> --- >> PVE/Storage.pm | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/PVE/Storage.pm b/PVE/Storage.pm >> index 6112991..efa304a 100755 >> --- a/PVE/Storage.pm >> +++ b/PVE/Storage.pm >> @@ -486,6 +486,8 @@ sub check_volume_access { >> } elsif ($vtype eq 'backup' && $ownervm) { >> $rpcenv->check($user, "/storage/$sid", ['Datastore.AllocateSpace']); >> $rpcenv->check($user, "/vms/$ownervm", ['VM.Backup']); @Fabian G. should access to backups also be allowed if the user /just/ has Datastore.Allocate? Otherwise, backups cannot be listed or removed (there is a separate check, but works similarly) and attributes cannot be changed by a supposedly high-privileged user. On the other hand, we also use this check for extractconfig, where it makes sense to be limited to users with VM.Backup, but could be changed at the call site of course. >> + } elsif (($vtype eq 'images' || $vtype eq 'rootdir') && $ownervm) { >> + $rpcenv->check($user, "/vms/$ownervm", ['VM.Config.Disk']); > > Of course this needs to be or-ed with the Datastore.Allocate privilege. > Will fix it in v2. > >> } else { >> # allow if we are Datastore administrator >> $rpcenv->check($user, "/storage/$sid", ['Datastore.Allocate']); > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >