From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 96798909D6 for ; Wed, 15 Mar 2023 14:23:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F2F73A3A1 for ; Wed, 15 Mar 2023 14:23:13 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 15 Mar 2023 14:23:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id ED423417B0 for ; Wed, 15 Mar 2023 14:23:09 +0100 (CET) Message-ID: <8ea5bbf5-127e-1a8c-15d2-e092b0ddea7d@proxmox.com> Date: Wed, 15 Mar 2023 14:23:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:111.0) Gecko/20100101 Thunderbird/111.0 Content-Language: de-AT, en-GB To: Proxmox VE development discussion , Christoph Heiss References: <20230315122635.286988-1-c.heiss@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20230315122635.286988-1-c.heiss@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH installer] fix #4430: add UTC timezone as option to installer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Mar 2023 13:23:14 -0000 Am 15/03/2023 um 13:26 schrieb Christoph Heiss: > The 'Etc/UTC' timezone does not have a definite 2-letter country code > assigned. 'xx' was choosen on the basis that this hopefully will never > be assigned to any real country in the future, but a small collision > check won't hurt either. > > This also means it does not have an entry in either the ISO-codes > definition file nor the zoneinfo table, thus needing to define it > manually. > > Using just 'UTC' as timezone (name) also matches what PVE/PMG/PBS do in > their UI. > > Signed-off-by: Christoph Heiss > --- > Some bike-shedding: If there is a better suggestion on what country code > to choose, I'll happily change it. Something like xx is fine in general, it's the simplest way to integrate this, so I'd base the exact used letters purely on sorting, > > Also, although the correct timezone name is 'Etc/UTC', I chose 'UTC' as > "country name" to display in the installer to make it easier to find for > users, as they probably will just type 'UTC' in there at first, rather > than 'Etc'. > That's fine too. What I don't like as much that one has to set the country to the timezone, which is confusing UX and will be subtle to most. Better ways might be: - add an explicit "Use UTC" checkbox that grey's out the country/timezone selection then. Disadvantage here would be taking up extra space and expanding the user input amount, which goes a bit against our "as simple as possible" approach for the installer - Add UTC always to the time-zone selection, independent of what country is selected. This keeps the selection where it belongs, and allows to quickly change to UTC without any typing/searching required (at least for most countries) >From a gut feeling I'd go for the second option, but didn't checked out how the implementation would then look like.