From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id E0CF61FF173 for <inbox@lore.proxmox.com>; Mon, 13 Jan 2025 11:54:36 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 701812BE54; Mon, 13 Jan 2025 11:54:20 +0100 (CET) Message-ID: <8e6fefc1-879b-4c98-a412-d633bd4dc50a@proxmox.com> Date: Mon, 13 Jan 2025 11:54:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner <f.ebner@proxmox.com> To: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>, "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>, "f.gruenbichler@proxmox.com" <f.gruenbichler@proxmox.com> References: <mailman.214.1734340397.332.pve-devel@lists.proxmox.com> <1841615375.1037.1736431994704@webmail.proxmox.com> <mailman.191.1736495114.441.pve-devel@lists.proxmox.com> <ba801ed2-5a65-4ab1-81e3-122a2d522006@proxmox.com> <8f309dfe189379acf72db07398a37a98e8fc3550.camel@groupe-cyllene.com> <84883d1c-08d7-4c46-bfc2-aab5a0d1c3e1@proxmox.com> Content-Language: en-US In-Reply-To: <84883d1c-08d7-4c46-bfc2-aab5a0d1c3e1@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.051 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES v3 pve-storage/qemu-server/pve-qemu] add external qcow2 snapshot support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Am 13.01.25 um 11:06 schrieb Fiona Ebner: > Am 10.01.25 um 13:30 schrieb DERUMIER, Alexandre: >> blockdev-reopen don't work with autogenerated nodenames (block#<id>) >> (not sure if it's a bug or not). >> That's why I'm currently naming all of them (including backing chain >> snapshots too) > > Hmm, sounds like it might a bug, I can look into it. If really required > to make it work, we can still set fixed node-names on the commandline, > but also query them before usage to be sure we have the correct, i.e. > currently inserted node. AFAICT, this is because the node name is not set in the original options for the block driver state and then it wrongly detects an attempt to change the node name (even if specifying the correct auto-generated one during reopen). However, it is rather ugly to try and use a -drive together with blockdev-reopen in any case, blockdev-reopen is really written with -blockdev in mind and -blockdev necessarily requires setting node-name up front. I don't think it's even worth fixing that bug. We should use blockdev-reopen only after switching to -blockdev, it's much nicer like that :) I'd still be in favor of querying the node-name of drives with query-block before doing QMP operations though. Like that, we can warn/error if it doesn't match what we expect for example, to catch unexpected situations. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel