From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 175416241D for ; Mon, 21 Feb 2022 16:35:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0BFDA1B58C for ; Mon, 21 Feb 2022 16:35:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 908D21B580 for ; Mon, 21 Feb 2022 16:35:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 644B7462E0 for ; Mon, 21 Feb 2022 16:35:32 +0100 (CET) Message-ID: <8dcb4681-16b1-9a67-5462-30a821e9b509@proxmox.com> Date: Mon, 21 Feb 2022 16:35:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-US To: Proxmox VE development discussion , Aaron Lauterer References: <20220218113827.1415641-1-a.lauterer@proxmox.com> <20220218113827.1415641-2-a.lauterer@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220218113827.1415641-2-a.lauterer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH librados2-perl 1/6] mon_command: free outs buffer X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 21 Feb 2022 15:35:33 -0000 On 18.02.22 12:38, Aaron Lauterer wrote: > Signed-off-by: Aaron Lauterer > --- > > thanks @Dominik who realized that we did not free this buffer in all > situations. > note that the status string is normally only allocated in the error case, where we freed it already, so actual impact shouldn't be that big; still definitively more correct this way ;) > RADOS.xs | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/RADOS.xs b/RADOS.xs > index 7eca024..1eb0b5a 100644 > --- a/RADOS.xs > +++ b/RADOS.xs > @@ -145,6 +145,10 @@ CODE: > RETVAL = newSVpv(outbuf, outbuflen); > > rados_buffer_free(outbuf); > + > + if (outs != NULL) { fyi: I made all calls to rados_buffer_free unconditional as the code there checks already for null-ness (not that it'd matter much, free(NULL) is a no-op) and it makes librados' built-in tracing more complete. > + rados_buffer_free(outs); fyi: above had a tab in a file that uses space only indentation. > + } > } > OUTPUT: RETVAL > applied, thanks!