From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AE4A839E for ; Tue, 15 Nov 2022 13:30:34 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1998D272B for ; Tue, 15 Nov 2022 13:30:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 15 Nov 2022 13:30:03 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5DF2D44C00 for ; Tue, 15 Nov 2022 13:30:03 +0100 (CET) Message-ID: <8d4f1004-d65c-5407-6071-27080ab19b0e@proxmox.com> Date: Tue, 15 Nov 2022 13:30:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Thunderbird/107.0 Content-Language: en-GB To: Proxmox VE development discussion , Fiona Ebner References: <20221115101830.59803-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221115101830.59803-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.182 Adjusted score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict =?UTF-8?Q?Alignment=0A=09?=POISEN_SPAM_PILL 0.1 Meta: its =?UTF-8?Q?spam=0A=09?=POISEN_SPAM_PILL_1 0.1 random spam to be learned in =?UTF-8?Q?bayes=0A=09?=POISEN_SPAM_PILL_3 0.1 random spam to be learned in =?UTF-8?Q?bayes=0A=09?=SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF =?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF =?UTF-8?Q?record=0A=09?=URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [backup.pm, jobs.pm] Subject: [pve-devel] applied: [PATCH manager] api: backup: auto-inject job id where expected by the API X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2022 12:30:34 -0000 Am 15/11/2022 um 11:18 schrieb Fiona Ebner: > for backwards compatibility. Otherwise, e.g. listing backup jobs with > pvesh get /cluster/backup is broken. And suddenly not having the > property anymore would be a breaking API change. > > Signed-off-by: Fiona Ebner > --- > > I didn't see any other places that rely on the $job->{id} to be set. > The other backup-related API calls and Jobs.pm iterate or check the > ids from the section config's $parsed->{ids}. Scheduler doesn't need > either AFAICT. > > @Dominik: I guess you need to adapt the (not-yet-applied) realm sync > jobs API too now that the id is not auto-injected. > > PVE/API2/Backup.pm | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > applied, thanks!