From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 887F79D0A3 for ; Wed, 25 Oct 2023 10:31:34 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 61C2811B9F for ; Wed, 25 Oct 2023 10:31:04 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 25 Oct 2023 10:31:03 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 256C245D8B; Wed, 25 Oct 2023 10:31:03 +0200 (CEST) Message-ID: <8d06d2f6-b831-45b3-ac1b-2cc3f1721b85@proxmox.com> Date: Wed, 25 Oct 2023 10:30:48 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: "DERUMIER, Alexandre" , "pve-devel@lists.proxmox.com" , "aderumier@odiso.com" References: <20230928144556.2023558-1-aderumier@odiso.com> <20230928144556.2023558-3-aderumier@odiso.com> <5ecfa7d0-4525-5f1e-75a2-a6ae1a93356b@proxmox.com> <73e0a3a6-f978-ac24-5f6b-16af759ee209@proxmox.com> <016bd4b8-7502-48fe-9208-a075e8aea02b@proxmox.com> <283ff207e6065f0ae178410bfa391e9a5369924f.camel@groupe-cyllene.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <283ff207e6065f0ae178410bfa391e9a5369924f.camel@groupe-cyllene.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.085 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 qemu-server 2/2] remote-migration: add target-cpu && target-reboot params X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Oct 2023 08:31:34 -0000 Am 24.10.23 um 14:20 schrieb DERUMIER, Alexandre: >>> So I think the best way for now is to restart the target vm. >>> >>> Sure! Going with that is a much cleaner approach then. > > I'll try to send a v5 today with you're last comments. > > I don't manage yet the unused disks, I need to test with blockdev, > Is it required for this series? Unused disks can just be migrated offline via storage_migrate(), or? If we want to switch to migrating disks offline via QEMU instead of our current storage_migrate(), going for QEMU storage daemon + NBD seems the most natural to me. If it's not too complicated to temporarily attach the disks to the VM, that can be done too, but is less re-usable (e.g. pure offline migration won't benefit from that). > but if it's work, I think we'll need to add config generation in pve- > storage for differents blockdriver > > > like: > > –blockdev driver=file,node-name=file0,filename=vm.img > > –blockdev driver=rbd,node-name=rbd0,pool=my-pool,image=vm01 > What other special cases besides (non-krbd) RBD are there? If it's just that, I'd much rather keep the special handling in QEMU itself then burden all other storage plugins with implementing something specific to VMs. Or is there a way to use the path from the storage plugin somehow like we do at the moment, i.e. "rbd:rbd/vm-111-disk-1:conf=/etc/pve/ceph.conf:id=admin:keyring=/etc/pve/priv/ceph/rbd.keyring"? > So maybe it'll take a little bit more time. > > (Maybe a second patch serie later to implement it) > Yes, I think that makes sense as a dedicated series.