From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id BB97660B3C for ; Tue, 11 Jan 2022 16:33:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B2CF5206A3 for ; Tue, 11 Jan 2022 16:33:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8F53C20693 for ; Tue, 11 Jan 2022 16:33:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5655A46C47 for ; Tue, 11 Jan 2022 16:33:32 +0100 (CET) Message-ID: <8cc44a11-22ac-eb9c-c21a-6dac58e357ad@proxmox.com> Date: Tue, 11 Jan 2022 16:33:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20220111102621.2443645-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220111102621.2443645-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: fix novnc scaling radio buttons X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 15:33:33 -0000 On 11.01.22 11:26, Dominik Csapak wrote: > when having selected 'off', the next start of the window has both > radiobuttons selected and no change is possible anymore. It seems that > the 'checked: true' triggers only after the 'init' function. > > So instead remove the 'checked: true', and add the default in the init > function. > > Signed-off-by: Dominik Csapak > --- > www/manager6/window/Settings.js | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > applied, thanks!