From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <l.nunner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 64AF991883
for <pve-devel@lists.proxmox.com>; Mon, 14 Nov 2022 13:24:00 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 4526C22FD4
for <pve-devel@lists.proxmox.com>; Mon, 14 Nov 2022 13:23:30 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Mon, 14 Nov 2022 13:23:28 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3755743D1A
for <pve-devel@lists.proxmox.com>; Mon, 14 Nov 2022 13:23:28 +0100 (CET)
Message-ID: <8c6067bb-a656-431b-df29-9b65b6149f89@proxmox.com>
Date: Mon, 14 Nov 2022 13:23:27 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
Thunderbird/102.4.0
Content-Language: en-US
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20221114120153.58169-1-l.nunner@proxmox.com>
<190c1ae8-721e-88a0-3c82-f8698dce7e4c@proxmox.com>
From: Leo Nunner <l.nunner@proxmox.com>
In-Reply-To: <190c1ae8-721e-88a0-3c82-f8698dce7e4c@proxmox.com>
X-SPAM-LEVEL: Spam detection results: =?UTF-8?Q?0=0A=09?=AWL -0.118 Adjusted
score from AWL reputation of From: =?UTF-8?Q?address=0A=09?=BAYES_00 -1.9
Bayes spam probability is 0 to 1%
HTML_MESSAGE 0.001 HTML included in =?UTF-8?Q?message=0A=09?=KAM_DMARC_STATUS
0.01 Test Rule for DKIM or SPF Failure with Strict
=?UTF-8?Q?Alignment=0A=09?=NICE_REPLY_A -0.001 Looks like a legit reply (A)
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF
=?UTF-8?Q?Record=0A=09?=SPF_PASS -0.001 SPF: sender matches SPF record
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [pve-devel] [PATCH storage] fix #3004: show progress of offline
migration in task log
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 14 Nov 2022 12:24:00 -0000
On 11/14/22 13:12, Thomas Lamprecht wrote:
> Am 14/11/2022 um 13:01 schrieb Leo Nunner:
>> dd supports a 'status' flag, which enables it to show the copied bytes,
>> duration, and the transfer rate, which then get printed to stderr.
>>
> can you post an excerpt of what it looks like and how frequent it outputs?
Currently, the output looks as following:
2022-11-14 12:01:00 236978176 bytes (237 MB, 226 MiB) copied, 1 s,
237 MB/s
2022-11-14 12:01:01 596377600 bytes (596 MB, 569 MiB) copied, 2 s,
298 MB/s
2022-11-14 12:01:02 947388416 bytes (947 MB, 904 MiB) copied, 3 s,
316 MB/s
2022-11-14 12:01:03 1308295168 bytes (1.3 GB, 1.2 GiB) copied, 4 s,
327 MB/s
2022-11-14 12:01:04 1673527296 bytes (1.7 GB, 1.6 GiB) copied, 5 s,
335 MB/s
[…]
> as unlike a TTY it cannot tell the console to override existing lines, so I
> guess this will do some periodic printing?
Yes, as of right now, it prints a new line every second. Maybe one
option to make it "prettier"
would be to limit the lines printed (by, say, only printing every nth
line/second), which should
be rather simple to implement by matching the dd output in Storage.pm,
where log lines are
already being parsed [1].
[1] https://git.proxmox.com/?p=pve-storage.git;a=blob;f=PVE/Storage.pm#l824