From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 430A570F30 for ; Tue, 10 May 2022 09:00:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 315ED3E55 for ; Tue, 10 May 2022 08:59:42 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A0A8C3E4A for ; Tue, 10 May 2022 08:59:41 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6F5A943279 for ; Tue, 10 May 2022 08:59:41 +0200 (CEST) Message-ID: <8c565e03-162f-fd39-5c30-8d5d077bfcc5@proxmox.com> Date: Tue, 10 May 2022 08:59:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Content-Language: en-US To: Thomas Lamprecht , Proxmox VE development discussion References: <20220509071733.23055-1-f.ebner@proxmox.com> <20220509071733.23055-2-f.ebner@proxmox.com> <74b9c359-c889-8279-76d3-7cf234cd90de@proxmox.com> From: Fabian Ebner In-Reply-To: <74b9c359-c889-8279-76d3-7cf234cd90de@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.627 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.1 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 2/2] configs: vzdump: add notes-template default X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 May 2022 07:00:12 -0000 Am 09.05.22 um 13:52 schrieb Thomas Lamprecht: > On 09/05/2022 09:17, Fabian Ebner wrote: >> so users can see that it can be configured here. >> >> Signed-off-by: Fabian Ebner >> --- >> >> Causes a "configuration changed by distributor" dialogue when >> upgrading the package. >> >> configs/vzdump.conf | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/configs/vzdump.conf b/configs/vzdump.conf >> index a0075cfa..fe4b18ab 100644 >> --- a/configs/vzdump.conf >> +++ b/configs/vzdump.conf >> @@ -14,3 +14,4 @@ >> #script: FILENAME >> #exclude-path: PATHLIST >> #pigz: N >> +#notes-template: {{guestname}} > > not sure if a node specific config is a good place for this, I'd think no config > (frontend-only) or if we really want one then maybe datacenter.cfg so that its > cluster wide; we could alternatively also start supporting to have a pmxcfs hosted > vzdump.conf that is read too (node one would still take precedence if a setting > appears in both). Yes, adding a cluster-wide vzdump.conf could be worth it for such options. I still think we can leverage the existing mechanism of the node-specific defaults though. It already works for CLI and backup jobs that don't set notes-template themselves. It's just not filled-in the UI yet, like we do for mail address, backup mode and prune-settings, the first two of which also don't feel very node-specific to me. Of course having them be node-specific adds a little bit of extra flexibility, but that'd apply to notes-template too. This patch is just for documentation, but '{{guestname}}' is not the back-end default, which the patch might suggest. It's probably better to instead write #notes-template: TEMPLATE-STRING