From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8BCEB1FF15E for ; Mon, 13 Oct 2025 16:02:33 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3E9C815D14; Mon, 13 Oct 2025 16:02:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1760364130; x=1760968930; d=canarybit.eu; s=rsa1; h=content-transfer-encoding:content-type:in-reply-to:from:references:cc:to: subject:mime-version:date:message-id:from; bh=jdNFlopCPBn2unp75vapnYj2Ln58IGLWtd9fJ7SVqtY=; b=Oo0PhfjIjnDOkoLu5dxt/Q2q3rPjrjXqV/7ac9keTNweQv4UDPGSxzuGmVhjEvOO8gOrTCxnjLgZA mPH/tO5J+kmJc/smnvsgJiPih4oK++alGYICeV3aux9sqv186q2ZWllGHI1osovavsRkfbfeNGKWl1 GCubmBf8Nc8CtZNDLgnl8S/RlyfPGMj+EkdB23cfWb4eYxnjB05Iza1zKZj7x0X1+OYDweErPlsDUX R+xS72376/7VgM7GYReX1cCws0iKCVhDhX5cUySWoJLSGauvlpLD+RbOxDl9qYMLalhlkVLpZNty5C V9kOeBxaEl0VT4JTw/m75DFNFuH07Uw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1760364130; x=1760968930; d=canarybit.eu; s=ed1; h=content-transfer-encoding:content-type:in-reply-to:from:references:cc:to: subject:mime-version:date:message-id:from; bh=jdNFlopCPBn2unp75vapnYj2Ln58IGLWtd9fJ7SVqtY=; b=nZdQBLdsWWOXwRT1BS4wqrLEGM3YvuVSdcpKzKpHzMS5pkcC3fa2EfmfNdoVBzI/jZ9rSa3+WXxYV 0DtufcsAQ== X-HalOne-ID: 3568df09-a83d-11f0-9a9a-632fe8569f3f Message-ID: <8c2d3d17-4664-43fe-b777-885ac92ed0d4@canarybit.eu> Date: Mon, 13 Oct 2025 16:02:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Fiona Ebner , Proxmox VE development discussion References: <20251001151237.50385-1-anton.iacobaeus@canarybit.eu> <20251001151237.50385-4-anton.iacobaeus@canarybit.eu> <7fc5b715-23c8-4245-b65c-5760c5958d2f@proxmox.com> Content-Language: en-US From: Anton Iacobaeus In-Reply-To: <7fc5b715-23c8-4245-b65c-5760c5958d2f@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.006 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_MISSING 0.1 Missing DMARC policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_PASS -0.001 SPF: HELO matches SPF record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [canarybit.eu] Subject: Re: [pve-devel] [PATCH edk2-firmware v2 3/3] Add SCSI in NCCFV for TD guest X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Philipp Giersfeld Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 10/7/25 17:24, Fiona Ebner wrote: > Am 04.10.25 um 3:23 PM schrieb Anton Iacobaeus: >> From: Philipp Giersfeld >> >> The FV in `IntelTdx/IntelTdxX64.fdf` was split into two FVs, one for a >> TD guest and one for non-cc guest. The SCSI driver was moved to the >> non-cc NCCFV. In order for PVE to use an image with SCSI include the >> SCSI driver in the FV for TD guest. > > Did you already ask upstream whether they would be willing to include > SCSI for the TD guest or is there no interest? Some of it is already > guarded via _ENABLE flags anyways. I'm fine with going with this, but > it's always nice to have no more diff than necessary to upstream. > We asked upstream and they said that there is no architecture issue with the SCSI driver, but it is a matter of validation. As of now there are no plans to include it, but an official request for it could be made. The process will likely be lengthy however and they also mentioned that including the driver manually is a good option. >> Signed-off-by: Philipp Giersfeld >> Signed-off-by: Anton Iacobaeus > > Reviewed-by: Fiona Ebner > > Unfortunately, mailman ate the special line endings in the diff below, > so it's necessary to fix them up locally to be able to build the > package. Should there be another version of the series, please use > --transfer-encoding=base64 when sending the message with git. > Thank you for the review! I will clean up some things and make a v3. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel