From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 853037A64D for ; Tue, 5 Jul 2022 08:50:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 73C172C203 for ; Tue, 5 Jul 2022 08:50:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 5 Jul 2022 08:50:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A805E40F19 for ; Tue, 5 Jul 2022 08:50:19 +0200 (CEST) Message-ID: <8b99a757-e503-dfd8-53b9-5d7dbf9576ff@proxmox.com> Date: Tue, 5 Jul 2022 08:50:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:103.0) Gecko/20100101 Thunderbird/103.0 Content-Language: en-GB To: Proxmox VE development discussion , Dominik Csapak , Matthias Heiserer References: <20220629122322.816989-1-m.heiserer@proxmox.com> <58120bd2-2d68-3748-c7b7-547c0be861cf@proxmox.com> From: Thomas Lamprecht In-Reply-To: <58120bd2-2d68-3748-c7b7-547c0be861cf@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [RFC manager] fix #3248: GUI: storage: upload multiple files X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jul 2022 06:50:50 -0000 On 01/07/2022 16:21, Dominik Csapak wrote: > a few high level comments: > > (mentioned it already offline): the window is imho too big. we try to make it functional > at 1280x720 and for that the window is too tall. maybe make it automatically smaller > in that case? > > even with the big window, the columns are too narrow to be really functional. > filename/progress/etc were all cut off here with my test isos > (standard linux distro isos) > > the popping in&out of the task viewer is a bit irritating, since with fast > storage, i don't get a chance to really read the task log before > it closes on me.. i think it'd be better if we'd just poll the task > in the background and e.g. add a spinner to the progress bar > with: 'copying & verifying' (or similar) and only open the task > log in case of an error Storage and network links that are fast enough to make a GiB+ ISO file upload flicker may not be that rare but I'd think that it isn't the norm too. Maybe add a wrapper with at the top having a progress bar with completed/total uploads as progress indicator and a (maybe collapsible) panel below, with the current task log and nothing else, for when the upload(s) actually get processed/submitted. > > i can add the same isos multiple times. does that make sense? > i know i can use different target names for them, but what would > that be good for? imho preventing the user from uploading > the same iso multiple times would be good +1, makes not much sense IMO too. > > i can add isos while there are still ones uploading, was this intentional? > > i think what could make the whole thing a bit better in general is > by having the selecting and uploading part split into two windows: > > a select window where you select isos/enter checksums etc. > and when clicking start upload, open a different window with only > the names & progress. > > that way the window is not that overloaded and can be smaller > without losing any functionality Yeah making it more wizard like (i.e., splitting up steps into separate "view units") is often a good way to reduce complexity for both the devs and the users. > > also we generally don't use 'abort' but 'Cancel' > > remaining comments inline: >