From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DF9E81FF0B2 for ; Tue, 08 Sep 2026 16:22:31 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 27B8221615; Tue, 08 Sep 2026 16:22:21 +0200 (CEST) Message-ID: <8b0bb35d-8b39-4033-9e89-319065812d8f@proxmox.com> Date: Tue, 8 Sep 2026 16:22:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu v2 5/9] savevm-async: drop QIOChannel reference To: Erik Fastermann , pve-devel@lists.proxmox.com References: <20260907094744.131193-1-e.fastermann@proxmox.com> <20260907094744.131193-6-e.fastermann@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260907094744.131193-6-e.fastermann@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1788877323339 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.700 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 7AQPH2A4HRTRTEMOHRDY3APUMRFZXER3 X-Message-ID-Hash: 7AQPH2A4HRTRTEMOHRDY3APUMRFZXER3 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 07.09.26 um 11:49 AM schrieb Erik Fastermann: > qemu_file_new_impl() takes its own reference and qemu_fclose() drops > exactly one, so the reference from qio_channel_savevm_async_new() was > never released. The channel also holds a BlockBackend reference that > only its finalizer drops, so both leaked on every snapshot. >>From a quick look, it seems like there are places in upstream code that suffer from the same issue as well. For example, qemu_fopen_bdrv(). Could you check this and send patches upstream to fix the actually affected ones? https://www.qemu.org/docs/master/devel/submitting-a-patch.html