From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2D0968461 for ; Thu, 27 Jul 2023 11:23:30 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EEE2D95B8 for ; Thu, 27 Jul 2023 11:22:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 27 Jul 2023 11:22:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 50A8A40D60 for ; Thu, 27 Jul 2023 11:22:59 +0200 (CEST) Message-ID: <8b05932f-4903-d228-04d4-0415d31644af@proxmox.com> Date: Thu, 27 Jul 2023 11:22:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230727083759.19001-1-a.zeidler@proxmox.com> <20230727083759.19001-4-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230727083759.19001-4-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.001 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.09 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Jul 2023 09:23:30 -0000 Am 27.07.23 um 10:37 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler Reviewed-by: Fiona Ebner > diff --git a/src/PVE/VZDump/LXC.pm b/src/PVE/VZDump/LXC.pm > index 5783ffa..a2bcdd7 100644 > --- a/src/PVE/VZDump/LXC.pm > +++ b/src/PVE/VZDump/LXC.pm > @@ -395,6 +395,12 @@ sub archive { > push @$param, '--backup-id', $vmid; > push @$param, '--backup-time', $task->{backup_time}; > > + if (my $entries_max = $opts->{"performance"}->{"pbs-entries-max"}) { > + push $param->@*, '--entries-max', $entries_max; > + $self->loginfo("set max number of entries in memory for file-based backups to " > + ."$entries_max"); Style nit: not entirely sure if this is allowed by our style guide (because of the argument going over two lines but not separated from the parentheses) or if it should be one of > $self->loginfo( > "set max number of entries in memory for file-based backups to $entries_max"); > $self->loginfo( > "set max number of entries in memory for file-based backups to $entries_max" > );