From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1A65D90DDD for ; Mon, 19 Dec 2022 16:18:12 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E8F8629C9D for ; Mon, 19 Dec 2022 16:17:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 19 Dec 2022 16:17:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2ECA444D8B for ; Mon, 19 Dec 2022 16:17:39 +0100 (CET) Message-ID: <8af727e1-b008-0142-eab1-031026a9c4d8@proxmox.com> Date: Mon, 19 Dec 2022 16:17:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Sterz References: <20221219122343.288855-1-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20221219122343.288855-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.545 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.148 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server v3] cd rom handling: return a clearer error when there is no cd rom drive X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2022 15:18:12 -0000 On 19/12/2022 13:23, Stefan Sterz wrote: > when a vm is configured to use a physical cd rom drive but there is no > such drive a cryptic "uninitialized value" error is thrown. this is > due to `$path` not being defined in `sub > print_drive_commandline_full` in this case. warn that no cd rom drive > is available instead. > > note that the error was basically cosmetic as the vm would start just > fine. > > forum thread: https://forum.proxmox.com/threads/119592/ > > Signed-off-by: Stefan Sterz > --- > changes from v2 (thanks @ Fiona Ebner): > > * added newline to message > * cache the fact that no drive is available so we warn only once > * adjusted error message again > > changes from v1: > > * make the error message more concise. > * use shorter forum link for better formatting in commit message > (thanks @ Fiona Ebner). > > PVE/QemuServer.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm > index dd6ea3e..11626cf 100644 > --- a/PVE/QemuServer.pm > +++ b/PVE/QemuServer.pm > @@ -1287,11 +1287,14 @@ sub option_exists { > my $cdrom_path; > sub get_cdrom_path { > > - return $cdrom_path if $cdrom_path; > + return $cdrom_path if defined($cdrom_path); > > return $cdrom_path = "/dev/cdrom" if -l "/dev/cdrom"; > return $cdrom_path = "/dev/cdrom1" if -l "/dev/cdrom1"; > return $cdrom_path = "/dev/cdrom2" if -l "/dev/cdrom2"; > + > + warn "no physical CD-ROM available\n"; why not use `log_warn` so that it shows up in the task worker log prominently (and handles the trailing newline itself)? also maybe end the sentence with "available for auto-selection" ? > + return $cdrom_path = ''; I know you did not start this, but I really do not like returning the result of an assignment in dynamically-"typed" languages like perl, it's totally unclear what side effects could be for most; anyhow can be addressed independent of this patch. > } > > sub get_iso_path {