From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E9F4B1FF13A for ; Wed, 22 Jul 2026 15:01:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 294F5214D8; Wed, 22 Jul 2026 15:01:43 +0200 (CEST) Message-ID: <8abb29af-e16d-456b-ab14-cd423abdd801@proxmox.com> Date: Wed, 22 Jul 2026 15:01:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2 2/2] fix #7828: avoid parsing absolute paths as volume ids To: Thomas Ellmenreich , pve-devel@lists.proxmox.com References: <20260722095251.89606-1-t.ellmenreich@proxmox.com> <20260722095251.89606-3-t.ellmenreich@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260722095251.89606-3-t.ellmenreich@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784725271992 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.227 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HGJKC6I3AUV3JTIEA2TWTAGMNFGGNECV X-Message-ID-Hash: HGJKC6I3AUV3JTIEA2TWTAGMNFGGNECV X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 22.07.26 um 11:53 AM schrieb Thomas Ellmenreich: > Just like in the case of cdroms, absolute paths to storage drives can be > skipped when beeing marked as unused as they cannot be owned by the vm. > > Fixes: 5b5c5768 ("display warnings for storage errors or if storage no longer exists") > Signed-off-by: Thomas Ellmenreich > --- > src/PVE/QemuServer.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm > index ce832c8e..ce0eda74 100644 > --- a/src/PVE/QemuServer.pm > +++ b/src/PVE/QemuServer.pm > @@ -1575,7 +1575,7 @@ sub vmconfig_register_unused_drive { > eval { PVE::Storage::vdisk_free($storecfg, $drive->{file}) }; > warn $@ if $@; > delete $conf->{'special-sections'}->{cloudinit}; > - } elsif (!drive_is_cdrom($drive)) { > + } elsif (!drive_is_cdrom($drive) && !drive_is_absolute_path($drive)) { > my $volid = $drive->{file}; > my ($storeid, undef) = PVE::Storage::parse_volume_id($volid); To fix the regression, I would prefer to use the noerr variant of parse_volume_id() here, because that is what tells us whether the volume is PVE-managed or not. We already do that in some other places like import. And then continue only if we got a result for $storeid. > if (PVE::Storage::storage_config($storecfg, $storeid, 1)) {