From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 9555E1FF161 for ; Tue, 13 Aug 2024 10:48:10 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C95BD3E094; Tue, 13 Aug 2024 10:48:23 +0200 (CEST) Message-ID: <8a84aa06-fb91-4d9d-9686-6bb8ed1ef388@proxmox.com> Date: Tue, 13 Aug 2024 10:47:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Fiona Ebner To: pve-devel@lists.proxmox.com References: <20240809101712.37212-1-f.ebner@proxmox.com> Content-Language: en-US In-Reply-To: <20240809101712.37212-1-f.ebner@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.054 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH qemu-server] remote migration: fix online migration via API clients X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 09.08.24 um 12:17 schrieb Fiona Ebner: > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index e71face4..7a7183e0 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -1095,7 +1095,8 @@ sub phase2 { > die "only UNIX sockets are supported for remote migration\n" > if $tunnel_info->{proto} ne 'unix'; > > - my $remote_socket = $tunnel_info->{addr}; > + my ($remote_socket) = $tunnel_info->{addr} =~ m!^(/run/qemu-server/.*\.migrate)$! #untaint I sent a v2 to rule out "../" in the regex: https://lists.proxmox.com/pipermail/pve-devel/2024-August/065075.html _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel