From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 391106D4E4 for ; Fri, 5 Feb 2021 09:42:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 275D92D090 for ; Fri, 5 Feb 2021 09:42:05 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AFB2E2D083 for ; Fri, 5 Feb 2021 09:42:04 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 718844618D for ; Fri, 5 Feb 2021 09:42:04 +0100 (CET) To: pve-devel@lists.proxmox.com, s.reiter@proxmox.com References: <20210204125224.25059-1-s.reiter@proxmox.com> <20210204125224.25059-4-s.reiter@proxmox.com> From: Fabian Ebner Message-ID: <89d3a6c0-23f8-eb59-9bf4-c33d693d118a@proxmox.com> Date: Fri, 5 Feb 2021 09:42:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210204125224.25059-4-s.reiter@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.087 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.182 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager 4/4] ui: snapshot: show task viewer for progress log X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 05 Feb 2021 08:42:35 -0000 Am 04.02.21 um 13:52 schrieb Stefan Reiter: > Signed-off-by: Stefan Reiter > --- > www/manager6/window/Snapshot.js | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/www/manager6/window/Snapshot.js b/www/manager6/window/Snapshot.js > index 2fa97041..a5fddd0f 100644 > --- a/www/manager6/window/Snapshot.js > +++ b/www/manager6/window/Snapshot.js > @@ -139,7 +139,8 @@ Ext.define('PVE.window.Snapshot', { > if (me.isCreate) { > subject = (me.type === 'qemu' ? 'VM' : 'CT') + me.vmid + ' ' + gettext('Snapshot'); > me.method = 'POST'; > - me.showProgress = true; > + me.showProgress = !me.running; > + me.showTaskViewer = me.running; Nit: Should this be based on the 'vmstate' parameter instead? The task log for a running VM without including the state contains the same lines as for a shut down VM (those about the drives), so it feels a little inconsistent to show it in one situation, but not in the other. > } else { > subject = `${gettext('Snapshot')} ${me.snapname}`; > me.url += `/${me.snapname}/config`; >