From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3153398737 for ; Mon, 9 Oct 2023 08:45:43 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12B4A13C2F for ; Mon, 9 Oct 2023 08:45:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 9 Oct 2023 08:45:10 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A0C72447A7 for ; Mon, 9 Oct 2023 08:45:10 +0200 (CEST) Message-ID: <899c8911-3f07-28d8-2e28-b035e5b17e21@proxmox.com> Date: Mon, 9 Oct 2023 08:45:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 To: Thomas Lamprecht , Proxmox VE development discussion References: <20231005140546.88771-1-f.ebner@proxmox.com> <08051548-fddc-4fa5-984e-fc3e34469328@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <08051548-fddc-4fa5-984e-fc3e34469328@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.828 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.818 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manager.pm] Subject: Re: [pve-devel] applied-series: [PATCH ha-manager 1/2] fix #4984: recompute online usage: add service usage to migration target only if online X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Oct 2023 06:45:43 -0000 Am 06.10.23 um 18:10 schrieb Thomas Lamprecht: > Am 05/10/2023 um 16:05 schrieb Fiona Ebner: >> Otherwise, when using the 'basic' plugin, this would lead to >> autovivification of the $target node in the Perl hash tracking the >> usage and it would wrongly be considered online when selecting the >> recovery node. >> >> The 'static' plugin was not affected, because it would check and warn >> before adding usage to a node that was not registered with add_node() >> first. Doing the same in the 'basic' plugin will be done by another >> patch. >> >> Signed-off-by: Fiona Ebner >> --- >> src/PVE/HA/Manager.pm | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> > > applied both patches with slightly rewording/shortening the commit message > subject, thanks! Does it make sense for stable-7 too or is this too much of an edge case? The bug report was with Proxmox VE 7.