From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D7F8B1FF164 for <inbox@lore.proxmox.com>; Fri, 9 May 2025 12:30:36 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CB0C03AA17; Fri, 9 May 2025 12:30:50 +0200 (CEST) Date: Fri, 9 May 2025 12:30:12 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com> To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Message-ID: <893680352.12923.1746786612624@webmail.proxmox.com> In-Reply-To: <mailman.23.1745322744.394.pve-devel@lists.proxmox.com> References: <20250422115141.808427-1-alexandre.derumier@groupe-cyllene.com> <mailman.23.1745322744.394.pve-devel@lists.proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev75 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.046 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH qemu-server 13/14] blockdev: add backing_chain support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> > Alexandre Derumier via pve-devel <pve-devel@lists.proxmox.com> hat am 22.04.2025 13:51 CEST geschrieben: > We need to define name-nodes for all backing chain images, > to be able to live rename them with blockdev-reopen > > For linked clone, we don't need to definebase image(s) chain. > They are auto added with #block nodename. > > Signed-off-by: Alexandre Derumier <alexandre.derumier@groupe-cyllene.com> > --- > PVE/QemuServer/Drive.pm | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm > index 08b893a1..0737034d 100644 > --- a/PVE/QemuServer/Drive.pm > +++ b/PVE/QemuServer/Drive.pm > @@ -1249,6 +1249,37 @@ sub generate_format_blockdev { > return $blockdev; > } > > +sub generate_backing_blockdev { make this private? > + my ($storecfg, $snapshots, $deviceid, $drive, $snap_id) = @_; > + > + my $snapshot = $snapshots->{$snap_id}; > + my $parentid = $snapshot->{parent}; > + > + my $volid = $drive->{file}; > + > + my $snap_file_blockdev = generate_file_blockdev($storecfg, $drive, $snap_id); > + $snap_file_blockdev->{filename} = $snapshot->{file}; > + $drive->{ro} = 1; > + my $snap_fmt_blockdev = generate_format_blockdev($storecfg, $drive, $snap_file_blockdev, $snap_id); > + $snap_fmt_blockdev->{backing} = generate_backing_blockdev($storecfg, $snapshots, $deviceid, $drive, $parentid) if $parentid; > + return $snap_fmt_blockdev; > +} > + > +sub generate_backing_chain_blockdev { > + my ($storecfg, $deviceid, $drive) = @_; > + > + my $volid = $drive->{file}; > + my $snapshot_type = PVE::Storage::volume_has_feature($storecfg, 'snapshot', $volid); > + return if !$snapshot_type || $snapshot_type != 3; this can just be $snapshot_type != 3.. should we move this check to the caller? and make this helper private? > + > + my $chain_blockdev = undef; drop this > + PVE::Storage::activate_volumes($storecfg, [$volid]); > + my $snapshots = PVE::Storage::volume_snapshot_info($storecfg, $volid); > + my $parentid = $snapshots->{'current'}->{parent}; return undef if !$parentid; > + $chain_blockdev = generate_backing_blockdev($storecfg, $snapshots, $deviceid, $drive, $parentid) if $parentid; return generate_backing_blockdev(...); > + return $chain_blockdev; > +} > + > sub generate_drive_blockdev { > my ($storecfg, $drive, $live_restore_name) = @_; > > @@ -1266,6 +1297,8 @@ sub generate_drive_blockdev { > > my $blockdev_file = generate_file_blockdev($storecfg, $drive); > my $blockdev_format = generate_format_blockdev($storecfg, $drive, $blockdev_file); > + my $backing_chain = generate_backing_chain_blockdev($storecfg, "drive-$drive_id", $drive); > + $blockdev_format->{backing} = $backing_chain if $backing_chain; > > #pflash0 don't support throttle-filter > return $blockdev_format if $drive_id eq 'pflash0'; > -- > 2.39.5 _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel