From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7DAD771621 for ; Wed, 8 Jun 2022 17:48:58 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6D686B213 for ; Wed, 8 Jun 2022 17:48:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0BC9DB206 for ; Wed, 8 Jun 2022 17:48:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CDE5443A7E for ; Wed, 8 Jun 2022 17:48:26 +0200 (CEST) Message-ID: <8934c89b-8320-212b-d527-8e064d637dae@proxmox.com> Date: Wed, 8 Jun 2022 17:48:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.0 To: Proxmox VE development discussion , Stefan Hrdlicka References: <20220608153457.955356-1-s.hrdlicka@proxmox.com> <20220608153457.955356-2-s.hrdlicka@proxmox.com> Content-Language: en-GB From: Thomas Lamprecht In-Reply-To: <20220608153457.955356-2-s.hrdlicka@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.870 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -1.732 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [zfs.pm] Subject: Re: [pve-devel] [PATCH V2 storage 1/3] fix #3967: enable ZFS dRAID creation via API X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jun 2022 15:48:58 -0000 Am 08/06/2022 um 17:34 schrieb Stefan Hrdlicka: > It is possible to set the number of spares and the size of > data stripes via draidspares & dreaddata parameters. > looks functional but din't test it, some api design suggestions and small style nits inline. > Signed-off-by: Stefan Hrdlicka > --- > PVE/API2/Disks/ZFS.pm | 44 ++++++++++++++++++++++++++++++++++++++++++- > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Disks/ZFS.pm b/PVE/API2/Disks/ZFS.pm > index eeb9f48..571bc90 100644 > --- a/PVE/API2/Disks/ZFS.pm > +++ b/PVE/API2/Disks/ZFS.pm > @@ -299,12 +299,28 @@ __PACKAGE__->register_method ({ > raidlevel => { > type => 'string', > description => 'The RAID level to use.', > - enum => ['single', 'mirror', 'raid10', 'raidz', 'raidz2', 'raidz3'], > + enum => [ > + 'single', 'mirror', > + 'raid10', 'raidz', 'raidz2', 'raidz3', > + 'draid', 'draid2', 'draid3', > + ], > }, > devices => { > type => 'string', format => 'string-list', > description => 'The block devices you want to create the zpool on.', > }, > + draiddata => { > + type => 'integer', > + minimum => 1, > + optional => 1, > + description => 'The number of data devices per redundancy group. (dRAID)', > + }, > + draidspares => { > + type => 'integer', > + minimum => 0, > + optional => 1, > + description => 'Number of dRAID spares.', > + }, I'd like above two to be a single format string parameter to avoid bloating the API too much with specialized/context-dependent params. my $draid_config_format = { spares => { type => 'integer', minimum => 0, description => 'Number of dRAID spares.', }, data => { .... }, }; (note that I made the format options non-optional by design). 'draid-config' => { type => 'string', format => $draid_config_format, optional => 1, } could be also more generically named than draid specific, but I don't see that many settings in the same spirit still coming in the future. FWIW, we could also deprecate raidlevel and use a new "raid" named parameter with "type" + the above config keys as parameter, but that's creeping up the scope of this a bit too much, can also be something for a next major version. > ashift => { > type => 'integer', > minimum => 9, > @@ -339,6 +355,8 @@ __PACKAGE__->register_method ({ > my $devs = [PVE::Tools::split_list($param->{devices})]; > my $raidlevel = $param->{raidlevel}; > my $compression = $param->{compression} // 'on'; > + my $draid_data = $param->{draiddata}; > + my $draid_spares = $param->{draidspares}; > > for my $dev (@$devs) { > $dev = PVE::Diskmanage::verify_blockdev_path($dev); > @@ -354,6 +372,9 @@ __PACKAGE__->register_method ({ > raidz => 3, > raidz2 => 4, > raidz3 => 5, > + draid => 3, > + draid2 => 4, > + draid3 => 5, > }; > > # sanity checks > @@ -366,6 +387,22 @@ __PACKAGE__->register_method ({ > die "$raidlevel needs at least $mindisks->{$raidlevel} disks\n" > if $numdisks < $mindisks->{$raidlevel}; > > + # draid checks > + if ($raidlevel =~ m/^draid/) { > + # bare minimum would be two drives: > + # one parity & one data drive this code doesn't allow that because > + # it makes no sense, at least one spare disk should be used > + my $draidmin = $mindisks->{$raidlevel} - 2; > + $draidmin += $draid_data if $draid_data; > + $draidmin += $draid_spares if $draid_spares; > + > + die "At least $draidmin disks needed for current dRAID config\n" > + if $numdisks < $draidmin; > + } else { > + die "draidspares and/or draiddata set without using dRAID" > + if ($draid_spares or $draid_data); style nit, parenthesis are not required for such simple post-if and we more commonly use `||` over `or` > + } > + > my $code = sub { > for my $dev (@$devs) { > PVE::Diskmanage::assert_disk_unused($dev); > @@ -402,6 +439,11 @@ __PACKAGE__->register_method ({ > } > } elsif ($raidlevel eq 'single') { > push @$cmd, $devs->[0]; > + } elsif ($raidlevel =~ m/^draid/) { > + my $draid_cmd = $raidlevel; > + $draid_cmd .= ":${draid_data}d" if $draid_data; > + $draid_cmd .= ":${draid_spares}s" if $draid_spares; > + push @$cmd, $draid_cmd, @$devs; > } else { > push @$cmd, $raidlevel, @$devs; > }