From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id F0D321FF138
	for <inbox@lore.proxmox.com>; Mon, 20 Jul 2026 14:21:54 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 2B376214AC;
	Mon, 20 Jul 2026 14:21:54 +0200 (CEST)
Message-ID: <890db7c0-3ab7-4087-8ca3-6fe88a92b21c@proxmox.com>
Date: Mon, 20 Jul 2026 14:21:50 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird Beta
Subject: Re: [PATCH pve-storage v2 03/17] api: plugins/storage: add initial
 routes and endpoints
To: "Max R. Carrara" <m.carrara@proxmox.com>, pve-devel@lists.proxmox.com
References: <20260717154943.696411-1-m.carrara@proxmox.com>
 <20260717154943.696411-4-m.carrara@proxmox.com>
Content-Language: en-US
From: Jakob Klocker <j.klocker@proxmox.com>
In-Reply-To: <20260717154943.696411-4-m.carrara@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1784550085962
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.962 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: 7YFZ4G3O3MGTH3FRYN42E7Y7OXOBOXFD
X-Message-ID-Hash: 7YFZ4G3O3MGTH3FRYN42E7Y7OXOBOXFD
X-MailFrom: j.klocker@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

missed a nit before

On 7/17/26 5:50 PM, Max R. Carrara wrote:
[snip]
> +        return $result;
> +    },
> +});

style-nit: newline is missing

> +1;