From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2BD9C5E2 for ; Fri, 7 Jul 2023 14:54:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BA40029881 for ; Fri, 7 Jul 2023 14:54:01 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 7 Jul 2023 14:54:00 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6D7F540A44 for ; Fri, 7 Jul 2023 14:54:00 +0200 (CEST) Message-ID: <890371e3-a0fb-03b3-9019-a8fb8e64d59a@proxmox.com> Date: Fri, 7 Jul 2023 14:53:59 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: Proxmox VE development discussion , Alexander Zeidler References: <20230615141445.188274-1-a.zeidler@proxmox.com> <20230615141445.188274-3-a.zeidler@proxmox.com> From: Fiona Ebner In-Reply-To: <20230615141445.188274-3-a.zeidler@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.000 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.091 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 manager 2/4] api: backup: add 'pbs-entries-max' to permission check & config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jul 2023 12:54:01 -0000 Am 15.06.23 um 16:14 schrieb Alexander Zeidler: > configuring pbs-entries-max can avoid failing backups due to a high > amount of files in folders where a folder exclusion is not possible > > Signed-off-by: Alexander Zeidler > --- > Changes from v1: > Add 'pbs-entries-max' according to the new shortened permission check > > PVE/API2/Backup.pm | 2 +- > configs/vzdump.conf | 1 + > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm > index 70753c2e..206ef1d9 100644 > --- a/PVE/API2/Backup.pm > +++ b/PVE/API2/Backup.pm > @@ -49,7 +49,7 @@ sub assert_param_permission_common { > raise_param_exc({ $key => "Only root may set this option."}) if exists $param->{$key}; > } > > - if (grep { defined($param->{$_}) } qw(bwlimit ionice performance)) { > + if (grep { defined($param->{$_}) } qw(bwlimit ionice performance pbs-entries-max)) { This is not needed, as it's a sub-option of performance now. > $rpcenv->check($user, "/", [ 'Sys.Modify' ]); > } > } > diff --git a/configs/vzdump.conf b/configs/vzdump.conf > index 2ea09ae0..2fbf3999 100644 > --- a/configs/vzdump.conf > +++ b/configs/vzdump.conf > @@ -16,3 +16,4 @@ > #exclude-path: PATHLIST > #pigz: N > #notes-template: {{guestname}} > +#pbs-entries-max: N It's not a lone-standing option, but part of performance.