From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id F25191FF136 for ; Mon, 04 May 2026 18:20:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C09068917; Mon, 4 May 2026 18:20:39 +0200 (CEST) Message-ID: <88e5fb20-3130-432a-a94e-27762be7393b@proxmox.com> Date: Mon, 4 May 2026 18:20:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-ve-rs v2 07/25] ve-config: sdn: fabrics: add wireguard to the fabric config To: Hannes Laimer , pve-devel@lists.proxmox.com References: <20260402081148.76276-1-s.hanreich@proxmox.com> <20260402081148.76276-8-s.hanreich@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.662 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MZUAQKBBI5SFYFNM4YFIQ64F2STDJZQC X-Message-ID-Hash: MZUAQKBBI5SFYFNM4YFIQ64F2STDJZQC X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 5/4/26 5:58 PM, Hannes Laimer wrote: > On 2026-04-02 10:14, Stefan Hanreich wrote: >> Use the newly created WireGuard section types to add the WireGuard >> variants to the existing fabrics section config enum. By adding the >> new WireGuard variants, they are automatically exposed via the API >> methods defined in proxmox-perl-rs and are available for the existing >> CRUD endpoints in pve-network. >> >> Originally-by: Christoph Heiss >> Signed-off-by: Stefan Hanreich >> --- > > [..] > >> @@ -36,6 +37,18 @@ api_string_type! { >> pub struct NodeId(String); >> } >> >> +impl std::str::FromStr for NodeId { >> + type Err = anyhow::Error; >> + >> + fn from_str(value: &str) -> Result { >> + Self::API_SCHEMA >> + .unwrap_string_schema() >> + .check_constraints(value)?; >> + >> + Ok(unsafe { Self::from_string_unchecked(value.to_string()) }) >> + } >> +} > > proxmox-schema already emits a `impl FromStr` for this > > generally there are some merge conflicts if applied on top of the latest > route-maps/prefix-list series[1], nothing dramatic, just wanted to note > it > > didn't get much further than build this on top of [1] today, will look > at the code more closely and do some testing tomorrow > > Conincidentally just sent a new version [1] that should address this, among other thing. [1] https://lore.proxmox.com/pve-devel/20260504161115.408970-1-s.hanreich@proxmox.com/T/#t