From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2BD5F93D7D for ; Wed, 22 Feb 2023 16:25:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0FF081AA1A for ; Wed, 22 Feb 2023 16:25:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 22 Feb 2023 16:25:39 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 322404814F; Wed, 22 Feb 2023 16:25:39 +0100 (CET) Message-ID: <88b50089-0645-b0b7-ce55-38ed5382ecc7@proxmox.com> Date: Wed, 22 Feb 2023 16:25:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: Proxmox VE development discussion , Alexandre Derumier References: <20230213120021.3783742-1-aderumier@odiso.com> From: Fiona Ebner In-Reply-To: <20230213120021.3783742-1-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.095 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH v4 qemu-server 00/16] rework memory hotplug + virtiomem X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Feb 2023 15:25:40 -0000 Am 13.02.23 um 13:00 schrieb Alexandre Derumier: > This patch series rework the current memory hotplug + virtiomem. > > memory option now have extra options: > > memory: [[current=]] [,max=] [,virtio=<1|0>] > ex: memory: current=1024,max=131072,virtio=1 > > > for classic memory hotplug, when maxmemory is defined, > we use 64 fixed size dimm. > The max option is a multiple of 64GB. > > The virtio option enable new virtio-mem support, > instead of plugging dimm, it's add/removed block inside > big dimm. > virtio-mem can use 32000 blocks, the blocksize is compute from > max memory. > > Looking good :) I just have a few suggestions for further improvements and there's a wrong function call in 11/16. Consider everything with no answer (or with just nits if you don't change the patch): Reviewed-by: Fiona Ebner Still, would be nice if you could address (some of) the nits too.