From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9C5531FF13F for ; Thu, 26 Mar 2026 13:55:59 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A940811CA1; Thu, 26 Mar 2026 13:56:14 +0100 (CET) Message-ID: <88a50335-f75b-4c6b-b2c6-ed906e3c7013@proxmox.com> Date: Thu, 26 Mar 2026 13:55:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH qemu-server v2 4/4] qga: rename guest-fsfreeze to freeze-fs To: Thomas Lamprecht , pve-devel@lists.proxmox.com References: <20260325213415.3861690-1-t.lamprecht@proxmox.com> <20260325213415.3861690-5-t.lamprecht@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20260325213415.3861690-5-t.lamprecht@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774529691360 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AKG6ONFT4ZVRFKR4UAUE6LRRZEDADEU7 X-Message-ID-Hash: AKG6ONFT4ZVRFKR4UAUE6LRRZEDADEU7 X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Am 25.03.26 um 10:34 PM schrieb Thomas Lamprecht: > These settings are already in the (QEMU guest) agent property, and we > do not use the guest- prefix for any of the existing properties > (fstrim or freeze-fs-on-backup), and moving freeze-fs-on-backup to a > generic variant is less confusing if one just drops the "-on-backup" > part, i.e. no point in inventing a new name schema just for the sake > of it. There's an inconsistency in naming between fstrim and freeze-fs too, but maybe we shouldn't care. > > We already rolled this the guest-fsfreeze name to pve-test, so lets > add an alias, but as we do not provide API stability guarantees for > test packages this is really just for convenience for anybody that > tested this, I'm more than fine with dropping such a (never stable) > released key again on a major release with the respective upgrade > check in our pveXtoY tool. > > Signed-off-by: Thomas Lamprecht Reviewed-by: Fiona Ebner