From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 73A6568E63 for ; Tue, 22 Mar 2022 09:48:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 642931B6D3 for ; Tue, 22 Mar 2022 09:47:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D5F831B6C7 for ; Tue, 22 Mar 2022 09:47:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A39AD46F41 for ; Tue, 22 Mar 2022 09:47:40 +0100 (CET) Message-ID: <889b6521-ab25-534b-17d3-ec789387139e@proxmox.com> Date: Tue, 22 Mar 2022 09:47:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Content-Language: en-US To: pve-devel@lists.proxmox.com, Matthias Heiserer References: <20220318135226.2360890-1-m.heiserer@proxmox.com> <20220318135226.2360890-4-m.heiserer@proxmox.com> From: Fabian Ebner In-Reply-To: <20220318135226.2360890-4-m.heiserer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.119 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH manager 3/5 v2] Backup GUI: Use the new storage/BackupView instead of grid/BackupView. X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2022 08:48:11 -0000 There's certain things that need to be changed to not break existing work flows: * Restoring doesn't overwrite the existing guest anymore and can't be used for that anymore. * Should not only filter by ID, but by type + ID. * Cannot get rid of the ID filtering anymore. Currently, it always filters by type, so we might want to keep that behavior. Nit: introducing the guest-view specific functionality to the BackupView class could've been part of this patch (or its own preparatory one), but not sure if it's worth the effort (anymore). Am 18.03.22 um 14:52 schrieb Matthias Heiserer: > Signed-off-by: Matthias Heiserer > --- > www/manager6/lxc/Config.js | 2 +- > www/manager6/qemu/Config.js | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/www/manager6/lxc/Config.js b/www/manager6/lxc/Config.js > index 89b59c9b..242780c8 100644 > --- a/www/manager6/lxc/Config.js > +++ b/www/manager6/lxc/Config.js > @@ -256,7 +256,7 @@ Ext.define('PVE.lxc.Config', { > me.items.push({ > title: gettext('Backup'), > iconCls: 'fa fa-floppy-o', > - xtype: 'pveBackupView', > + xtype: 'pveStorageBackupView', > itemId: 'backup', > }, > { > diff --git a/www/manager6/qemu/Config.js b/www/manager6/qemu/Config.js > index 9fe933df..3ed2427a 100644 > --- a/www/manager6/qemu/Config.js > +++ b/www/manager6/qemu/Config.js > @@ -291,7 +291,7 @@ Ext.define('PVE.qemu.Config', { > me.items.push({ > title: gettext('Backup'), > iconCls: 'fa fa-floppy-o', > - xtype: 'pveBackupView', > + xtype: 'pveStorageBackupView', > itemId: 'backup', > }, > {