From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D213A9254C for ; Mon, 12 Sep 2022 17:16:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C00FC783F for ; Mon, 12 Sep 2022 17:15:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 12 Sep 2022 17:15:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE7FB433D8 for ; Mon, 12 Sep 2022 17:15:35 +0200 (CEST) Message-ID: <889998f9-57d4-906e-cbf9-c4be0244725b@proxmox.com> Date: Mon, 12 Sep 2022 17:15:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:105.0) Gecko/20100101 Thunderbird/105.0 Content-Language: en-GB To: Proxmox VE development discussion , Stefan Sterz References: <20220907093740.172217-1-s.sterz@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220907093740.172217-1-s.sterz@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.008 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: [PATCH widget-toolkit] fix: toolkit: make email regex pattern match pve-common X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2022 15:16:06 -0000 Am 07/09/2022 um 11:37 schrieb Stefan Sterz: > `proxmoxMail` used its own regex pattern to validate emails. that > meant certain email addresses were rejected by the front-end that > were accepted by the backend that uses the functionality from > `pve-common`. examples include the following: > > - "user@host.test-tld" > - "user-@host.testtld" > - "user@host" > > reported on the forum: https://forum.proxmox.com/threads/gui-bugulance-using-the-user-add-gui-interface.114743/ > > Signed-off-by: Stefan Sterz > --- > note that there are many many regex patterns that could be used > (e.g.: [1]). im partial to w3c's approach [2], mainly because it's > likely to be widely used, while being fairly simple and compatible > with perl and javascript. > > [1]: https://www.ex-parrot.com/~pdw/Mail-RFC822-Address.html > [2]: https://html.spec.whatwg.org/multipage/input.html#valid-e-mail-address > > src/Toolkit.js | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > applied, thanks!