From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 6CD731FF16F for <inbox@lore.proxmox.com>; Thu, 13 Feb 2025 16:05:45 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 48BC37B93; Thu, 13 Feb 2025 16:05:40 +0100 (CET) From: Daniel Herzig <d.herzig@proxmox.com> To: Fiona Ebner <f.ebner@proxmox.com> In-Reply-To: <740ecb3b-6f74-49a7-9107-78cd0369dc30@proxmox.com> (Fiona Ebner's message of "Thu, 13 Feb 2025 11:23:24 +0100") References: <20250210120722.163622-1-d.herzig@proxmox.com> <20250210120722.163622-2-d.herzig@proxmox.com> <740ecb3b-6f74-49a7-9107-78cd0369dc30@proxmox.com> Date: Thu, 13 Feb 2025 16:05:04 +0100 Message-ID: <87y0y9dgwv.fsf@proxmox.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.391 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH 1/8 container] cloudinit: introduce config parameters X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> Fiona Ebner <f.ebner@proxmox.com> writes: > Am 10.02.25 um 13:07 schrieb Daniel Herzig: >> From: Leo Nunner <l.nunner@proxmox.com> >> >> Introduce configuration parameters for cloud-init. Like with VMs, it's >> possible to specify: >> - user >> - password >> - ssh keys >> - enable/disable updates on first boot >> >> It's also possible to pass through custom config files for the user and >> vendor settings. We don't allow configuring the network through >> cloud-init, since it will clash with whatever configuration we already >> did for the container. > > Since I didn't mention it yet, when you do changes, you should keep a > brief changelog of what changed between Leo's version and your version > in the git trailers, e.g.: > > Signed-off-by: Leo Nunner <l.nunner@proxmox.com> > [DH: add foo > refactor bar > fix regex for baz] > Signed-off-by: Daniel Herzig <d.herzig@proxmox.com> Thanks for the review and the input Fiona, I'll add this once I actually start changing stuff apart from the initial rebase! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel