From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 057741FF15F for ; Mon, 16 Dec 2024 09:39:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8656C6036; Mon, 16 Dec 2024 09:39:31 +0100 (CET) From: Daniel Herzig To: Stefan Hanreich In-Reply-To: (Stefan Hanreich's message of "Thu, 12 Dec 2024 18:12:23 +0100") References: <20241205163332.130930-1-d.herzig@proxmox.com> <20241205163332.130930-2-d.herzig@proxmox.com> Date: Mon, 16 Dec 2024 09:38:58 +0100 Message-ID: <87v7vkf2e5.fsf@proxmox.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.104 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common 1/4] fix #5900: add helper function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hi Stefan, thanks for the feedback. Thanks for hinting at ~PVE::LXC::Config::parse_lxc_network~. I oversaw that and did not want to pull ~PVE::QemuServer::parse_net~ into LXC's deps. Stefan Hanreich writes: > On 12/5/24 17:33, Daniel Herzig wrote: >> This patch adds a small helper function to retrieve the bridge name >> from the netN parameter string of a container or VM configuration. >> >> Signed-off-by: Daniel Herzig >> --- >> src/PVE/GuestHelpers.pm | 11 +++++++++++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/src/PVE/GuestHelpers.pm b/src/PVE/GuestHelpers.pm >> index 592b4a8..c6006ba 100644 >> --- a/src/PVE/GuestHelpers.pm >> +++ b/src/PVE/GuestHelpers.pm >> @@ -450,4 +450,15 @@ sub abort_guest_tasks { >> return $aborted_tasks; >> } >> >> +sub get_bridge { >> + my $net_params = shift; >> + my $param_array = [ split(/,/, $net_params) ]; >> + my $bridge; >> + for my $net_param (@$param_array) { >> + $bridge = $net_param if ($net_param =~ /bridge\=/); >> + $bridge =~ s|bridge\=|| if (defined($bridge)); >> + } >> + return $bridge; >> +} >> + >> 1; > > net is a property string, if you want to parse it there are helpers for > that in PVE::JSONSchema. > > For VMs as well as CTs we already have helpers for parsing the network > property string defined: > > PVE::QemuServer::parse_net > PVE::LXC::Config::parse_lxc_network _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel