From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <s.lendl@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id 7A6B096364
for <pve-devel@lists.proxmox.com>; Thu, 29 Feb 2024 16:12:42 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5B1B715DF4
for <pve-devel@lists.proxmox.com>; Thu, 29 Feb 2024 16:12:42 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Thu, 29 Feb 2024 16:12:38 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3D7A347FDA;
Thu, 29 Feb 2024 16:12:38 +0100 (CET)
From: Stefan Lendl <s.lendl@proxmox.com>
To: Roland <devzero@web.de>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
In-Reply-To: <6104c230-7e2e-43ae-8598-6c458b979ae1@web.de>
References: <20240125105658.1541023-2-s.lendl@proxmox.com>
<6104c230-7e2e-43ae-8598-6c458b979ae1@web.de>
Date: Thu, 29 Feb 2024 16:12:37 +0100
Message-ID: <87r0gv8ftm.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.032 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
T_SCC_BODY_TEXT_LINE -0.01 -
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [ksm-control-scripts.new]
Subject: Re: [pve-devel] [PATCH ksm-control-daemon] ksmtuned: fix large
number processing
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 29 Feb 2024 15:12:42 -0000
Roland <devzero@web.de> writes:
> oh, and shouldn't we also add that to total and free_memory calculation,
> even chances are less that the limit is hit there ?
>
> total=3D`awk '/^MemTotal:/ {print $2}' /proc/meminfo`
>
> free_memory () {
> =C2=A0=C2=A0=C2=A0 awk '/^(MemFree|Buffers|Cached):/ {free +=3D $2}; END=
{print free}' \
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0 /proc/meminfo
> }
>
> Am 25.01.24 um 11:56 schrieb Stefan Lendl:
>> diff --git a/debian/patches/awk-printf.diff b/debian/patches/awk-printf.=
diff
>> new file mode 100644
>> index 0000000..11a957f
>> --- /dev/null
>> +++ b/debian/patches/awk-printf.diff
>> @@ -0,0 +1,16 @@
>> +--- ksm-control-scripts/ksmtuned 2024-01-25 11:33:03.485039813 +0100
>> ++++ ksm-control-scripts.new/ksmtuned 2024-01-25 11:37:40.544751316 +0100
>> +@@ -72,11 +72,11 @@
>> + # calculate how much memory is committed to running qemu processes
>> + local progname
>> + progname=3D${1:-kvm}
>> +- ps -C "$progname" -o vsz=3D | awk '{ sum +=3D $1 }; END { print su=
m }'
>> ++ ps -C "$progname" -o vsz=3D | awk '{ sum +=3D $1 }; END { printf (=
"%.0f", sum) }'
>> + }
>> +
>> + free_memory () {
>> +- awk '/^(MemFree|Buffers|Cached):/ {free +=3D $2}; END {print free}=
' \
>> ++ awk '/^(MemFree|Buffers|Cached):/ {free +=3D $2}; END { printf ("%=
.0f", free) }' \
>> + /proc/meminfo
>> + }
>> +
Hi Roland, as you can see in the patch, I am also adding this to the
free_memory function.
The patches are applied during the build process, hence the actual
source file still looks unchanged if you're looking at it in the repo.
If you install the package, the updated files will be placed at
/usr/sbin/ksmtuned where you can inspect the result.