From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0D01B1FF15C for ; Wed, 8 Jan 2025 16:59:48 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 537A91E1C1; Wed, 8 Jan 2025 16:59:33 +0100 (CET) From: Daniel Herzig To: Gabriel Goller In-Reply-To: <20250108143812.241488-1-g.goller@proxmox.com> (Gabriel Goller's message of "Wed, 8 Jan 2025 15:38:09 +0100") References: <20250108143812.241488-1-g.goller@proxmox.com> Date: Wed, 08 Jan 2025 16:58:57 +0100 Message-ID: <87r05djnzy.fsf@proxmox.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.049 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, lxc.pm] Subject: Re: [pve-devel] [PATCH container/manager v4 0/3] Show container ip in summary and network tab X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: pve-devel@lists.proxmox.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" I just tested this series against an alpine container with sdn simple zone dhcp IP assignment and it seems to do what it promises. This makes a very nice streamlined experience with VM behaviour. Tested-by: Daniel Herzig Gabriel Goller writes: > Show the ip/hwaddress of the network interfaces of containers in the summary > tab of the container and in the network tab on a per-interface basis. > > This series was originally by Leo Nunner: > https://lore.proxmox.com/pve-devel/20230615094333.66179-1-l.nunner@proxmox.com/ > > v4, thanks @Daniel: > - remove duplicate code (copy paste error) > - rebase on latest master > > v3, thanks @Thomas, @Maximiliano: > - fixed wording in schema description > - stay backwards-compatible by keeping old attributes > - use array reference instead of array > > v2, thanks @Dominik: > - show if ip is static or dynamic (dhcp) > - show multiple ips per interface > - refactor/reuse AgentIPView instead of adding ContainerIPView component > - various other small improvements > > manager: > > Gabriel Goller (2): > lxc: show dynamically assigned IPs in network tab > guest: refactor and reuse AgentIPView for containers > > www/manager6/Makefile | 2 +- > www/manager6/lxc/Network.js | 85 +++++++---- > www/manager6/panel/GuestStatusView.js | 140 +++++++++++++++++- > www/manager6/panel/GuestSummary.js | 2 +- > .../{qemu/AgentIPView.js => panel/IPView.js} | 79 ++-------- > 5 files changed, 211 insertions(+), 97 deletions(-) > rename www/manager6/{qemu/AgentIPView.js => panel/IPView.js} (58%) > > > container: > > Gabriel Goller (1): > api: return all addresses of an interface > > src/PVE/API2/LXC.pm | 37 +++++++++++++++++++++++++++++++++++-- > src/PVE/LXC.pm | 15 +++++++++++++++ > 2 files changed, 50 insertions(+), 2 deletions(-) > > > Summary over all repositories: > 7 files changed, 261 insertions(+), 99 deletions(-) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel