From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id C738A1FF172
	for <inbox@lore.proxmox.com>; Wed, 23 Apr 2025 17:17:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id C7E3C1E300;
	Wed, 23 Apr 2025 17:17:07 +0200 (CEST)
From: Daniel Herzig <d.herzig@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>
In-Reply-To: <cb8be5b8-a469-4a12-9a61-851608060dbf@proxmox.com> (Daniel Kral's
 message of "Wed, 23 Apr 2025 16:45:37 +0200")
References: <20250423130315.360403-1-d.herzig@proxmox.com>
 <ed50bdc3-d508-42e4-b3ed-47848eab4e5a@proxmox.com>
 <87wmbbrn2k.fsf@proxmox.com>
 <cb8be5b8-a469-4a12-9a61-851608060dbf@proxmox.com>
Date: Wed, 23 Apr 2025 17:17:00 +0200
Message-ID: <87plh2syab.fsf@proxmox.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.391 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH pve-esxi-import-tools] fix #6347: do not
 break vm listing on invalid configs
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Daniel Kral <d.kral@proxmox.com> writes:

> On 4/23/25 16:04, Daniel Herzig wrote:
>>> Oops, I should have prefixed my patch with a "fix" at least, but I've
>>> sent two patches some days ago for this ;):
>>>
>>> https://lore.proxmox.com/pve-devel/20250411150634.253684-1-d.kral@proxmox.com/T/#u
>>>
>> Ha, I missed that one, you were too quick ;)
>> It turned out that the problem was on the specific ESXI-side config
>> (`vm.config` is there on ESXI-6.7.x as well, without it we could not do
>> anything anyway -- `fetch_and_update_vm_data` calls it more than
>> once inherently). But it's `None` for sure if there's an invalid vm config on the ESXI side.
>
> Thanks for the info!
>
> I was wondering why it didn't work for them (in the forum) and have
> only figured that there was something undocumented in the PyVim API
> about when the OptionType is None, but with either patch it should be
> fine now :).
>
I think so too!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel