From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 22C8B1FF190 for ; Fri, 24 Jan 2025 08:35:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 82C321940E; Fri, 24 Jan 2025 08:35:37 +0100 (CET) From: Daniel Herzig To: Friedrich Weber In-Reply-To: <169c861e-aa99-4f78-ae9d-82510c953630@proxmox.com> (Friedrich Weber's message of "Thu, 23 Jan 2025 17:39:18 +0100") References: <20250113085608.99498-1-d.herzig@proxmox.com> <20250113085608.99498-13-d.herzig@proxmox.com> <169c861e-aa99-4f78-ae9d-82510c953630@proxmox.com> Date: Fri, 24 Jan 2025 08:35:02 +0100 Message-ID: <87ikq41x7d.fsf@proxmox.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.275 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v2 12/12] ui: qemu: hardware: add eject button for cdroms X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Hi Friedrich, thanks for looking into this, this comes right in time, as I've so far finished v3 of the backend-part. Friedrich Weber writes: > Hi, I have two small things that I noticed skimming the series (inline). > > On 13/01/2025 09:56, Daniel Herzig wrote: >> Eject by setting file to none. >> >> Signed-off-by: Daniel Herzig >> --- >> www/manager6/qemu/HardwareView.js | 43 +++++++++++++++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> >> diff --git a/www/manager6/qemu/HardwareView.js b/www/manager6/qemu/HardwareView.js >> index 59e670db..5d1c18a5 100644 >> --- a/www/manager6/qemu/HardwareView.js >> +++ b/www/manager6/qemu/HardwareView.js >> @@ -538,6 +538,45 @@ Ext.define('PVE.qemu.HardwareView', { >> apiurl: '/api2/extjs/' + baseurl, >> }); >> >> + let eject_btn = new Proxmox.button.Button({ >> + text: gettext('Eject'), >> + disabled: true, >> + selModel: sm, >> + RESTMethod: 'POST', >> + confirmMsg: function(rec) { >> + let warn = gettext("Are you sure you want to eject '{0}' ?"); >> + let isofile = rec.data.value.split(",")[0]; > > Not a frontend expert, but it might be nicer to use something like > PVE.Parser.parsePropertyString to retrieve the ISO name here, instead of > manually splitting the string. > Perfect, will switch to using this. >> + let msg = Ext.String.format(warn, isofile); >> + return msg; > > This should be html-encoded before displaying, e.g. using Ext.htmlEncode. Thanks for this one as well! _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel