From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
	by lore.proxmox.com (Postfix) with ESMTPS id 56DB11FF15E
	for <inbox@lore.proxmox.com>; Tue,  8 Apr 2025 11:27:12 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 359A0F8DE;
	Tue,  8 Apr 2025 11:27:08 +0200 (CEST)
From: Daniel Herzig <d.herzig@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
In-Reply-To: <rf464d4lpsr6gbpgcrv6233yq56r3fgjvxzfcv6seslqt7wk6h@kdp6jnu7sylc>
 (Wolfgang Bumiller's message of "Tue, 8 Apr 2025 11:17:12 +0200")
References: <20250407150422.293994-1-d.herzig@proxmox.com>
 <rf464d4lpsr6gbpgcrv6233yq56r3fgjvxzfcv6seslqt7wk6h@kdp6jnu7sylc>
Date: Tue, 08 Apr 2025 11:27:03 +0200
Message-ID: <875xjft34o.fsf@proxmox.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.388 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [broadcom.com]
Subject: Re: [pve-devel] [PATCH esxi-import-tools] listvms: exclude VMs
 without datastore_name from manifest.json.
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: pve-devel@lists.proxmox.com
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Wolfgang Bumiller <w.bumiller@proxmox.com> writes:

>>          for vm in list_vms(connection):
>> +            # skip vms with empty datastore_name
>> +            datastore_name, relative_vmx_path = parse_file_path(
>> +                vm.config.files.vmPathName
>> +            )
>> +            if not datastore_name:
>
> While this works as a stop-gap, I think we should use the example code
> here[1] to test if this is such an embedded(?) vCLS VM, and if it is
> *not* such a VM, print a warning to stderr that we're skipping this VM,
> so that in the future, if VMs magically disappear, we should see log
> messages about this.
>
> [1]
> https://knowledge.broadcom.com/external/article/370219/script-identification-for-embedded-vcls.html

I agree -- above is more of a handbrake-solution. I'll see what I can do
for proper indentification. Thanks a lot for the link, I missed that
there's more focussed identifiers available already.

>
>> +                continue
>>              try:
>>                  fetch_and_update_vm_data(vm, data)
>>              except Exception as err:
>> -- 
>> 2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel