From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
by lore.proxmox.com (Postfix) with ESMTPS id 3383C1FF172
for <inbox@lore.proxmox.com>; Tue, 1 Apr 2025 10:05:09 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 0CA671B976;
Tue, 1 Apr 2025 10:04:57 +0200 (CEST)
Message-ID: <8744ae16-6185-4430-9d58-a2e8ecf467c5@proxmox.com>
Date: Tue, 1 Apr 2025 10:04:53 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
References: <20250331094135.100410-1-f.weber@proxmox.com>
Content-Language: en-US
From: =?UTF-8?Q?Michael_K=C3=B6ppl?= <m.koeppl@proxmox.com>
In-Reply-To: <20250331094135.100410-1-f.weber@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL 0.000 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [report.pm]
Subject: Re: [pve-devel] [PATCH manager] report: add WWN column to lsblk
output
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
On 3/31/25 11:41, Friedrich Weber wrote:
> WWNs (WWIDs) are useful information for debugging setups where
> multipath is not (correctly) set up, as the WWN reveals which block
> devices point to the same LUN. The report currently does not provide
> WWNs in such scenarios. There is a symlink for the WWN under
> /dev/disk/by-id/wwn-*, but if there are multiple block devices with
> the same WWN, the symlink just points to one of them.
>
> Hence, add the WWN column to the lsblk output.
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> PVE/Report.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 1ed91c8e..8f53823e 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -117,7 +117,7 @@ my $init_report_cmds = sub {
> 'block devices' => {
> order => 80,
> cmds => [
> - 'lsblk --ascii -M -o +HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN',
> + 'lsblk --ascii -M -o +HOTPLUG,ROTA,PHY-SEC,FSTYPE,MODEL,TRAN,WWN',
> 'ls -l /dev/disk/by-*/',
> 'iscsiadm -m node',
> 'iscsiadm -m session',
Tested this by adding SCSI, IDE, and SATA hard disks to a VM and
manually setting a WWN via qm set. I noticed that the output of lsblk
does only show a WWN for the SCSI disk, but not for the others. smartctl
-i does return a WWN for the SATA disk and scsi_id also seems to
recognize the manually set value. I think it could make sense to add a
note to the documentation regarding the limitations of the lsblk output
in this regard?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel