From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id A6AE41FF164
	for <inbox@lore.proxmox.com>; Fri, 17 Jan 2025 13:39:23 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id D6712E6A6;
	Fri, 17 Jan 2025 13:39:21 +0100 (CET)
From: Daniel Herzig <d.herzig@proxmox.com>
To: Daniel Kral <d.kral@proxmox.com>
In-Reply-To: <8648f6fc-80e8-49c7-bb24-b20d6dd0f20c@proxmox.com> (Daniel Kral's
 message of "Thu, 16 Jan 2025 16:19:22 +0100")
References: <20250113085608.99498-1-d.herzig@proxmox.com>
 <20250113085608.99498-12-d.herzig@proxmox.com>
 <8648f6fc-80e8-49c7-bb24-b20d6dd0f20c@proxmox.com>
Date: Fri, 17 Jan 2025 13:38:48 +0100
Message-ID: <8734hhmx7r.fsf@proxmox.com>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.280 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked. See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 11/12] fix #4225: ui: qemu: cdedit:
 enable required checkbox for isos
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>

Daniel Kral <d.kral@proxmox.com> writes:

> On 1/13/25 09:56, Daniel Herzig wrote:
>> Enables the 'required' checkbox for the IsoSelector.
>> If the parameter is not set, the backend will use the default (set to
>> 1).
>> Behaviour:
>> * Only send parameter if not default (required=0)
>> * Checked if parameter is missing (default)
>> * Unchecked when adding a new CD-ROM
>
> IMO the part of this patch where new VMs get created with `required=0`
> CDROMs should be split into its own patch and marked as "for-9.0" or
> else add a TODO comment for the 9.0 release.
>
Good point to stay more 'conservative' for now. Thanks.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel