From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 32F1064B96 for ; Fri, 4 Mar 2022 11:18:44 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 1F13C2B3B for ; Fri, 4 Mar 2022 11:18:14 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E35402B2D for ; Fri, 4 Mar 2022 11:18:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B0A2A46E83 for ; Fri, 4 Mar 2022 11:18:12 +0100 (CET) Message-ID: <86e805dc-2def-1296-13bb-1712cc9ca8c0@proxmox.com> Date: Fri, 4 Mar 2022 11:18:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-GB To: Proxmox VE development discussion , Stoiko Ivanov References: <20220211151547.181259-1-s.ivanov@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220211151547.181259-1-s.ivanov@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied-series: Re: [PATCH pve-kernel-meta/proxmox-ve v3] proxmox-boot: add kernel pinning functionality (#3761) X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 10:18:44 -0000 On 11/02/2022 16:15, Stoiko Ivanov wrote: > pve-kernel-meta: > Stoiko Ivanov (4): > proxmox-boot: return empty if file does not exist in get_first_line > proxmox-boot: fix #3671 add pin/unpin for kernel-version > proxmox-boot: add --next-boot option kernel pin command > proxmox-boot: add pin/unpin functionality for non-p-b-t systems > > bin/proxmox-boot-tool | 97 +++++++++++++++++++++++ > debian/pve-kernel-helper.install | 1 + > debian/rules | 3 + > proxmox-boot/Makefile | 4 + > proxmox-boot/functions | 45 +++++++++++ > proxmox-boot/proxmox-boot-cleanup.service | 13 +++ > proxmox-boot/zz-proxmox-boot | 8 ++ > 7 files changed, 171 insertions(+) > create mode 100644 proxmox-boot/proxmox-boot-cleanup.service > > proxmox-ve: > Stoiko Ivanov (3): > apt-hook: fix perlcritic warnings > apt-hook: verify that fd is numeric > apt-hook: add check preventing the removal of pinned kernels > > debian/apthook/pve-apt-hook | 36 +++++++++++++++++++++++++++++++++--- > 1 file changed, 33 insertions(+), 3 deletions(-) > applied, thanks! amended the bug number in patch 2/4 (thx Oguz) and made some small followups (i had those lying around since a while and only committed now, I think I had some other small things in mind when revieiwing this originally, but nothing critical at all), mostly outputting possible pve kversions options to choose from in some error cases and outputting when a previous pin gets overridden with new one. We could add a proxmox-ve Breaks: pve-kernel-helper (<< 7.1-13) to ensure this always works cleanly (not that a pinnend kernel gets removed) but the case when this can happen is very odd and people should really not hold back upgrading proxmox-ve, makes not much sense to do.