From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 45DEE1FF163 for ; Thu, 24 Oct 2024 17:05:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7757910766; Thu, 24 Oct 2024 17:05:34 +0200 (CEST) Message-ID: <85f03434-d2e9-49bd-a39f-406c3eb6dd59@proxmox.com> Date: Thu, 24 Oct 2024 17:05:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht , Proxmox VE development discussion References: <20241021091542.1017657-1-d.csapak@proxmox.com> <20241021091542.1017657-3-d.csapak@proxmox.com> <0a006d35-4f1c-40cd-a148-31e15ed27253@proxmox.com> Content-Language: en-US From: Dominik Csapak In-Reply-To: <0a006d35-4f1c-40cd-a148-31e15ed27253@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] applied: [PATCH container 1/1] status: add some missing descriptions for status return properties X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 10/24/24 14:20, Thomas Lamprecht wrote: > Am 21/10/2024 um 11:15 schrieb Dominik Csapak: >> Signed-off-by: Dominik Csapak >> --- >> src/PVE/LXC.pm | 43 ++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 42 insertions(+), 1 deletion(-) >> > > > applied, thanks! FYI: I had to fix a duplicate key (see below) and made a few > small adjustments to the wording (not just your additions) as a separate follow-up. > >> + netin => { >> + description => "The amount of traffic that was sent to the guest since the process start," >> + ." in bytes.", >> + type => 'integer', >> + optional => 1, >> + renderer => 'bytes', >> + }, >> + netin => { > > changed this to netout and folded that into your commit. uff, thanks for that. seems i was too fast with the copy&paste... i wonder if our check target could catch something like that, but probably not i guess _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel