From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id F0E2069A5F for ; Tue, 23 Mar 2021 14:31:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EBCF82F1E7 for ; Tue, 23 Mar 2021 14:30:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7D3A92F1DB for ; Tue, 23 Mar 2021 14:30:49 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4AB9E428FF for ; Tue, 23 Mar 2021 14:30:49 +0100 (CET) To: Proxmox VE development discussion , Oguz Bektas References: <20210322140045.763332-1-o.bektas@proxmox.com> <20210322140045.763332-4-o.bektas@proxmox.com> From: Dylan Whyte Message-ID: <8595bace-77b0-54ae-e7c9-10aca6af1ac6@proxmox.com> Date: Tue, 23 Mar 2021 14:30:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210322140045.763332-4-o.bektas@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [utils.pm] Subject: Re: [pve-devel] [PATCH v3 http-server 3/3] utils: add LISTEN_IP option in /etc/default/pveproxy X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Mar 2021 13:31:20 -0000 Hi, Tested various valid input and seems to work for me. As discussed, one has to be careful to give local ipv6 addresses in the form `LISTEN_IP=fe80::...::4579%interface`, in order for these address types to work. Tested-by: Dylan Whyte Reviewed-by: Dylan Whyte  On 3/22/21 3:00 PM, Oguz Bektas wrote: > to allow setting arbitrary IP address to listen on > > Signed-off-by: Oguz Bektas > --- > PVE/APIServer/Utils.pm | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/PVE/APIServer/Utils.pm b/PVE/APIServer/Utils.pm > index e843e5f..36e3ae6 100644 > --- a/PVE/APIServer/Utils.pm > +++ b/PVE/APIServer/Utils.pm > @@ -14,6 +14,7 @@ sub read_proxy_config { > > # Note: evaluate with bash > my $shcmd = ". $conffile;\n"; > + $shcmd .= 'echo \"LISTEN_IP:\$LISTEN_IP\";'; > $shcmd .= 'echo \"ALLOW_FROM:\$ALLOW_FROM\";'; > $shcmd .= 'echo \"DENY_FROM:\$DENY_FROM\";'; > $shcmd .= 'echo \"POLICY:\$POLICY\";'; > @@ -36,6 +37,8 @@ sub read_proxy_config { > push @$ips, Net::IP->new($ip) || die Net::IP::Error() . "\n"; > } > $res->{$key} = $ips; > + } elsif ($key eq 'LISTEN_IP') { > + $res->{$key} = $value; > } elsif ($key eq 'POLICY') { > die "unknown policy '$value'\n" if $value !~ m/^(allow|deny)$/; > $res->{$key} = $value;