From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 840DA1FF17C for <inbox@lore.proxmox.com>; Wed, 2 Apr 2025 15:42:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E81C81BAFC; Wed, 2 Apr 2025 15:41:51 +0200 (CEST) Message-ID: <8579ba86-e3a5-462e-bebe-d71b4c6b126c@proxmox.com> Date: Wed, 2 Apr 2025 15:41:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Markus Frank <m.frank@proxmox.com> References: <20250304115803.194820-1-m.frank@proxmox.com> <20250304115803.194820-3-m.frank@proxmox.com> Content-Language: en-US From: Daniel Kral <d.kral@proxmox.com> In-Reply-To: <20250304115803.194820-3-m.frank@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH guest-common v14 2/12] add dir mapping section config X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> One small comment inline. Tested the obvious cases: - trying to add multiple map entries with the same node for the same dirid results in an error in the WebGUI - adding multiple map entries manually in the file for a dirid will make the VM fail to start with an error indicating that there are multiple paths for the same dirid and node, but only if it actually uses the mountpoint Else the patch looks good to me, consider this as: Reviewed-by: Daniel Kral <d.kral@proxmox.com> Tested-by: Daniel Kral <d.kral@proxmox.com> On 3/4/25 12:57, Markus Frank wrote: > Adds a config file for directories by using a 'map' property string for > each node mapping. > > Next to node & path, there is the optional announce-submounts parameter > which forces virtiofsd to report a different device number for each > submount it encounters. Without it, duplicates may be created because > inode IDs are only unique on a single filesystem. > > example config: > ``` > some-dir-id > map node=node1,path=/mnt/share/,announce-submounts=1 > map node=node2,path=/mnt/share/, nit: the trailing comma in the last map line will fail to display all directory mappings in the WebGUI because parsePropertyString() will return undefined in the ResourceMapTree component. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel