From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EAED98D12E for ; Mon, 7 Nov 2022 13:49:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C65112B341 for ; Mon, 7 Nov 2022 13:49:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 7 Nov 2022 13:49:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D738A4169D for ; Mon, 7 Nov 2022 13:41:14 +0100 (CET) Message-ID: <85592363-a30e-2975-df6b-131ac984dac4@proxmox.com> Date: Mon, 7 Nov 2022 13:41:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 To: pve-devel@lists.proxmox.com References: <20220824162644.1632804-1-aderumier@odiso.com> <20220824162644.1632804-6-aderumier@odiso.com> Content-Language: en-US From: Mira Limbeck In-Reply-To: <20220824162644.1632804-6-aderumier@odiso.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.266 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH V3 qemu-server 3/3] migration : add del_nets_bridge_fdb X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Nov 2022 12:49:01 -0000 On 8/24/22 18:26, Alexandre Derumier wrote: > at the end of a live migration, we need to remove old mac entries > on source host (vm is not yet stopped), before resume vm on target host > > Signed-off-by: Alexandre Derumier > --- > PVE/QemuMigrate.pm | 1 + > PVE/QemuServer.pm | 20 ++++++++++++++++++++ > test/MigrationTest/QemuMigrateMock.pm | 3 +++ > 3 files changed, 24 insertions(+) > > diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm > index d52dc8d..b72a3fe 100644 > --- a/PVE/QemuMigrate.pm > +++ b/PVE/QemuMigrate.pm > @@ -1157,6 +1157,7 @@ sub phase3_cleanup { > > # transfer replication state before move config > $self->transfer_replication_state() if $self->{is_replicated}; > + PVE::QemuServer::del_nets_bridge_fdb($conf, $vmid); I'm currently going through this patch series, and I'm wondering. Wouldn't it make more sense to delete the bridge fdb entries as part of the VM shutdown instead? This way those would be cleaned up whenever the VM is stopped (and the tap device gets destroyed). No special handling for migrations needed, unless I'm missing something?