From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 245DD1FF15D for ; Thu, 19 Sep 2024 17:36:32 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0960F1A3DF; Thu, 19 Sep 2024 17:36:39 +0200 (CEST) Message-ID: <8552728a-bc38-45d4-996c-e98014d0adae@proxmox.com> Date: Thu, 19 Sep 2024 17:36:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20240919143020.3725971-1-d.csapak@proxmox.com> From: Aaron Lauterer In-Reply-To: <20240919143020.3725971-1-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager] ui: backup job overview: add filter field X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" gave this a quick test spin and if I clear my search, the other backup jobs that did not match don't show up anymore. So resetting seems to be somewhat broken. On a more general level, the question is, if this approach will be sufficient or if we don't want something in the direction of "show me all backup jobs that cover this specific VMID". Which will need a bit more logic. Then the question is, do we want to handle that in the backend, where we already have it, or do we handle it purely in the frontend where we will need to replicate the logic. For example, all VMIDs on a node. all VMIDs except the selected. VMIDs in resource pools, ... On 2024-09-19 16:30, Dominik Csapak wrote: > so that users can easily search their jobs for comments, VMID and pool > names, in case there are many backup jobs. > > This partially addresses #5721, since one can search for vmid when they > are selected directly, but not when inside a pool. Still should be a > useful addition for users with many backup jobs. > > Signed-off-by: Dominik Csapak > --- > www/manager6/dc/Backup.js | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js > index 381402ca..a96eb5bf 100644 > --- a/www/manager6/dc/Backup.js > +++ b/www/manager6/dc/Backup.js > @@ -780,6 +780,45 @@ Ext.define('PVE.dc.BackupView', { > '-', > run_btn, > '->', > + { > + xtype: 'textfield', > + fieldLabel: gettext('Filter'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('Filters by Comment, VMID or Pool name'), > + }, > + triggers: { > + clear: { > + cls: 'pmx-clear-trigger', > + weight: -1, > + hidden: true, > + handler: function() { > + this.setValue(''); > + this.getTriggers().clear.setVisible(false); > + }, > + }, > + }, > + labelAlign: 'right', > + listeners: { > + change: { > + fn: function(search, val) { > + search.getTriggers().clear.setVisible(!!val); > + store.clearFilter(); > + store.filterBy((record) => { > + let found = false; > + for (const field of ['comment', 'vmid', 'pool']) { > + if (record.data[field]?.toString().includes(val)) { > + found = true; > + break; > + } > + } > + return found; > + }); > + }, > + buffer: 250, > + }, > + }, > + }, > noBackupJobInfoButton, > '-', > { _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel