From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <f.schauer@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by lists.proxmox.com (Postfix) with ESMTPS id C6CDC97758
for <pve-devel@lists.proxmox.com>; Wed, 17 Apr 2024 10:47:49 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id B7372C54
for <pve-devel@lists.proxmox.com>; Wed, 17 Apr 2024 10:47:49 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
[94.136.29.106])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by firstgate.proxmox.com (Proxmox) with ESMTPS
for <pve-devel@lists.proxmox.com>; Wed, 17 Apr 2024 10:47:49 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DD8AA404F4
for <pve-devel@lists.proxmox.com>; Wed, 17 Apr 2024 10:47:48 +0200 (CEST)
Message-ID: <854e58be-ff75-4d71-ae4c-fe80522a1301@proxmox.com>
Date: Wed, 17 Apr 2024 10:47:29 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20240416121002.135845-1-f.schauer@proxmox.com>
<20240416121002.135845-3-f.schauer@proxmox.com>
<96b03505-ddf8-4211-b935-4b2a4e6bdc66@proxmox.com>
Content-Language: en-US
From: Filip Schauer <f.schauer@proxmox.com>
In-Reply-To: <96b03505-ddf8-4211-b935-4b2a4e6bdc66@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.072 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
information. [proxmox.com]
Subject: Re: [pve-devel] [PATCH v4 manager 2/2] ui: lxc: add edit window for
device passthrough
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 17 Apr 2024 08:47:49 -0000
Changed in patch v5. I also fixed a bug that ignored a custom devid when
creating a device passthrough.
https://lists.proxmox.com/pipermail/pve-devel/2024-April/063108.html
On 16/04/2024 15:57, Fiona Ebner wrote:
> Am 16.04.24 um 14:10 schrieb Filip Schauer:
>> +
>> + cbind: {
>> + confid: '{confid}',
>> + isCreate: get => !get('confid'),
>> + },
> Can't the above be removed while...
>
>> +
>> + items: [
>> + {
>> + xtype: 'proxmoxintegerfield',
>> + name: 'devid',
>> + fieldLabel: gettext('Passthrough ID'),
>> + minValue: 0,
>> + maxValue: PVE.Utils.dev_count - 1,
>> + hidden: true,
>> + allowBlank: false,
>> + disabled: true,
>> + labelAlign: 'right',
>> + bind: {
> ...using cbind instead of bind here?
>
>> + hidden: '{!isCreate}',
>> + disabled: '{!isCreate}',
>> + },