From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A148BA404 for ; Wed, 13 Dec 2023 18:00:19 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 51F5BE341 for ; Wed, 13 Dec 2023 18:00:19 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 13 Dec 2023 18:00:17 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A87AA47108 for ; Wed, 13 Dec 2023 18:00:17 +0100 (CET) Message-ID: <84fbc31a-e0d4-40ae-866e-5428d77c45cb@proxmox.com> Date: Wed, 13 Dec 2023 18:00:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Fiona Ebner , Proxmox VE development discussion References: <20231212105853.41491-1-f.schauer@proxmox.com> <71e00bdc-335e-45ba-bc61-60ca3817d6c4@proxmox.com> From: Filip Schauer In-Reply-To: <71e00bdc-335e-45ba-bc61-60ca3817d6c4@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.170 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH v3 qemu-server] Prevent starting a 32-bit VM using a 64-bit OVMF BIOS X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Dec 2023 17:00:19 -0000 Patch v5 is available: https://lists.proxmox.com/pipermail/pve-devel/2023-December/061079.html On 12/12/2023 12:12, Fiona Ebner wrote: > Am 12.12.23 um 11:58 schrieb Filip Schauer: >> Instead of starting a VM with a 32-bit CPU type and a 64-bit OVMF image, >> throw an error before starting the VM telling the user that OVMF is not >> supported on 32-bit CPU types. >> >> Signed-off-by: Filip Schauer >> --- >> Changes since v2: >> * Simplify the check whether a 32-bit CPU type is used in combination >> with OVMF >> > Yes, it's much nicer than extending the EFI-related functions with new > parameters :) > >> PVE/QemuServer.pm | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm >> index 2063e66..b25a3cd 100644 >> --- a/PVE/QemuServer.pm >> +++ b/PVE/QemuServer.pm >> @@ -3570,6 +3570,16 @@ my sub print_ovmf_drive_commandlines { >> return ("if=pflash,unit=0,format=raw,readonly=on,file=$ovmf_code", $var_drive_str); >> } >> >> +my @cputypes_32bit = ( >> + '486', >> + 'pentium', >> + 'pentium2', >> + 'pentium3', >> + 'coreduo', >> + 'athlon', >> + 'kvm32', >> + 'qemu32', >> +); > I'd like to put this list in CPUConfig.pm and have a small helper > function there. The QemuServer.pm module already has way too many > functions and variables ;) And since it's only used for lookup, maybe > using a hash is better? > > A short comment in the commit message about how you got the list would > be nice too (I just checked for absence of CPUID_EXT2_LM in > target/i386/cpu.c to verify your list). > >> sub config_to_command { >> my ($storecfg, $vmid, $conf, $defaults, $forcemachine, $forcecpu, >> $pbs_backing) = @_; >> @@ -3689,6 +3699,9 @@ sub config_to_command { >> } >> >> if ($conf->{bios} && $conf->{bios} eq 'ovmf') { >> + die "OVMF (UEFI) BIOS is not supported on 32-bit CPU types\n" >> + if ($conf->{cpu} && first {$_ eq $conf->{cpu}} @cputypes_32bit); > Style nit: usually we don't have parentheses for post-if