From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 794811FF18F for ; Mon, 5 Aug 2024 08:58:21 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 627F93F534; Mon, 5 Aug 2024 08:58:27 +0200 (CEST) Message-ID: <84c1078a-1a68-445e-9073-9954abd42ba8@proxmox.com> Date: Mon, 5 Aug 2024 08:58:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stoiko Ivanov , Maximiliano Sandoval References: <20240802143414.170136-1-m.sandoval@proxmox.com> <20240802184127.05d03300@rosa.proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20240802184127.05d03300@rosa.proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage] storage: add bzip2 support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 8/2/24 18:41, Stoiko Ivanov wrote: >> >> [2] https://opnsense.org/download/ >> >> src/PVE/Storage.pm | 3 +++ >> src/PVE/Storage/Plugin.pm | 2 +- >> src/test/archive_info_test.pm | 6 ++++-- >> src/test/list_volumes_test.pm | 11 ++++++++++- >> src/test/parse_volname_test.pm | 4 ++-- >> src/test/path_to_volume_id_test.pm | 13 ++++++++----- >> 6 files changed, 28 insertions(+), 11 deletions(-) >> >> diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm >> index 57b2038..0caac71 100755 >> --- a/src/PVE/Storage.pm >> +++ b/src/PVE/Storage.pm >> @@ -1550,16 +1550,19 @@ sub decompressor_info { >> gz => ['tar', '-z'], >> lzo => ['tar', '--lzop'], >> zst => ['tar', '--zstd'], >> + bz2 => ['tar', '--bzip2'], >> }, >> vma => { >> gz => ['zcat'], >> lzo => ['lzop', '-d', '-c'], >> zst => ['zstd', '-q', '-d', '-c'], >> + bz2 => ['bzcat', '-q'], > ... but add it for tar and vma here? > (haven't tried if adding it only for one of the formats works explicitly > though) > Same as Stoiko, I was a bit surprised to finding this hunk here and the others related to vma archives further below as well, while looking at your patch. I suggest to add a bit more description to the commit message and additional context to the commit title as well. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel