From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2E940922E7 for ; Thu, 1 Feb 2024 14:28:51 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 16E72105D6 for ; Thu, 1 Feb 2024 14:28:51 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 1 Feb 2024 14:28:50 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D8B3940A7B for ; Thu, 1 Feb 2024 14:28:49 +0100 (CET) Message-ID: <84465309-959e-4ac6-87cb-942709982bb4@proxmox.com> Date: Thu, 1 Feb 2024 14:28:48 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pve-devel@lists.proxmox.com References: <20240130184041.1125674-1-m.carrara@proxmox.com> <20240130184041.1125674-2-m.carrara@proxmox.com> <1706701255.osw2c9wm3p.astroid@yuna.none> From: Max Carrara In-Reply-To: <1706701255.osw2c9wm3p.astroid@yuna.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.038 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pve-devel] [PATCH master ceph 1/8] debian: add patch to fix ceph crash dir permissions in postinst hook X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Feb 2024 13:28:51 -0000 On 1/31/24 14:18, Fabian Grünbichler wrote: > On January 30, 2024 7:40 pm, Max Carrara wrote: >> Ceph has a postinst hook that sets the ownership of '/var/lib/ceph/*' >> to ceph:ceph (in our case), but misses out on '/var/lib/ceph/crash/posted'. >> >> This patch therefore also updates the permissions of '/var/lib/ceph/*/*'. >> >> Signed-off-by: Max Carrara >> --- >> ...rmissions-of-subdirectories-of-var-l.patch | 42 +++++++++++++++++++ >> patches/series | 1 + >> 2 files changed, 43 insertions(+) >> create mode 100644 patches/0015-debian-adjust-permissions-of-subdirectories-of-var-l.patch >> >> diff --git a/patches/0015-debian-adjust-permissions-of-subdirectories-of-var-l.patch b/patches/0015-debian-adjust-permissions-of-subdirectories-of-var-l.patch >> new file mode 100644 >> index 000000000..951a2a6ed >> --- /dev/null >> +++ b/patches/0015-debian-adjust-permissions-of-subdirectories-of-var-l.patch >> @@ -0,0 +1,42 @@ >> +From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 >> +From: Max Carrara >> +Date: Thu, 11 Jan 2024 14:04:16 +0100 >> +Subject: [PATCH] debian: adjust permissions of subdirectories of /var/lib/ceph >> + >> +A rather recent PR made ceph-crash run as "ceph" user instead of >> +root [0]. However, because /var/lib/ceph/crash/posted belongs to root, >> +ceph-crash cannot actually post any crash logs now. >> + >> +This commit fixes this by also updating the permissions of >> +/var/lib/ceph/*/* - the subdirectories of the directories in >> +/var/lib/ceph. >> + >> +[0]: https://github.com/ceph/ceph/pull/48713 >> + >> +Signed-off-by: Max Carrara >> +--- >> + debian/ceph-base.postinst | 8 ++++++++ >> + 1 file changed, 8 insertions(+) >> + >> +diff --git a/debian/ceph-base.postinst b/debian/ceph-base.postinst >> +index 75eeb59c624..7ca0b9b6c43 100644 >> +--- a/debian/ceph-base.postinst >> ++++ b/debian/ceph-base.postinst >> +@@ -40,6 +40,14 @@ case "$1" in >> + chown $SERVER_USER:$SERVER_GROUP $DIR >> + fi >> + done >> ++ >> ++ # also adjust file and directory permissons for subdirectories >> ++ for SUBDIR in /var/lib/ceph/*/* ; do >> ++ if ! dpkg-statoverride --list $SUBDIR >/dev/null >> ++ then >> ++ chown $SERVER_USER:$SERVER_GROUP $SUBDIR >> ++ fi > > this would probably benefit from being merged with the loop above and > being switched to find? > > find(utils) is Essential, so its existence is a given.. Good point, seems sensible! > > did you forward this patch upstream? if not, please do so :) Will merge the two loops and use `find` instead and then also see if I can supply a PR upstream (was initially planning to do that once this patch is applied on our side). > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel > >