From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 319EC1FF17E for ; Thu, 2 Oct 2025 07:43:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 799E26D36; Thu, 2 Oct 2025 07:43:43 +0200 (CEST) Message-ID: <8408e8bf-6809-4722-baeb-e8f9263b73d2@proxmox.com> Date: Thu, 2 Oct 2025 07:43:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Proxmox VE development discussion , Stefan Hanreich References: <20251001162818.320717-1-s.hanreich@proxmox.com> Content-Language: en-US From: Hannes Laimer In-Reply-To: <20251001162818.320717-1-s.hanreich@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1759383796382 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [vm.rs, config.rs, rule.rs, object.rs, firewall.rs] Subject: Re: [pve-devel] [PATCH proxmox{-ve-rs, -firewall} v3 0/4] Fix ipfilters in proxmox-firewall X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Changes look good now! I also gave this a quick spin and it did fix the mentioned problems, so consider this Tested-by: Hannes Laimer Reviewed-by: Hannes Laimer On 10/1/25 18:28, Stefan Hanreich wrote: > This patch series addresses two issues with ipfilters: > > * containers would have the wrong CIDR inserted into the auto-generated ipfilter > ipsets > * The nomatch logic isn't working correctly, due to wrong inversion of logic, > leading to ipfilters not working at all > > Including the rustfmt patch here as well, instead of separately since we touch > some of the imports that get changed there - leading to conflicts on applying > otherwise. > > Changes from v2: > * fix wrong family when generating ipfilter rules for V6 > > Changes from v1: > * properly regenerate test-output with the proxmox-ve-rs patch applied > * improve documentation of handle_set and handle_ipfilter > > proxmox-ve-rs: > > Stefan Hanreich (1): > config: guest: store network devices in BTreeMap > > proxmox-ve-config/src/guest/vm.rs | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > > proxmox-firewall: > > Stefan Hanreich (3): > run rustfmt > ipfilter: fix wrong entries for containers > fix #6336: fix ipfilter matching logic > > proxmox-firewall/src/config.rs | 6 +- > proxmox-firewall/src/firewall.rs | 16 +- > proxmox-firewall/src/object.rs | 6 +- > proxmox-firewall/src/rule.rs | 161 +++++-- > proxmox-firewall/tests/input/100.conf | 1 + > .../integration_tests__firewall.snap | 416 ++++++++++++++++++ > 6 files changed, 565 insertions(+), 41 deletions(-) > > > Summary over all repositories: > 7 files changed, 569 insertions(+), 45 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel