From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8765E64C18 for ; Fri, 4 Mar 2022 11:40:56 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7E8F730A4 for ; Fri, 4 Mar 2022 11:40:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id EF0983099 for ; Fri, 4 Mar 2022 11:40:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C890C46EA7 for ; Fri, 4 Mar 2022 11:40:25 +0100 (CET) Message-ID: <83e2ab05-8607-978f-866b-b56e993c7b50@proxmox.com> Date: Fri, 4 Mar 2022 11:40:24 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:98.0) Gecko/20100101 Thunderbird/98.0 Content-Language: en-GB To: Proxmox VE development discussion , Fabian Ebner References: <20211029111624.142116-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20211029111624.142116-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.058 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: [pve-devel] applied: Re: [RFC v2 common 1/2] REST environment: add static log_warn function X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2022 10:40:56 -0000 On 29/10/2021 13:16, Fabian Ebner wrote: > which avoids the need for the caller to check whether the environment > was initialized or not. > > Signed-off-by: Fabian Ebner > --- > > Changes from v1: > * The static function now calls the class method, rather than the > other way around. If the current environment is a derived class > providing its own implementation of warn(), the static function > will call that one. > > src/PVE/RESTEnvironment.pm | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > applied, thanks!